Skip to content

Workaround to make smoke-test pass. #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2022
Merged

Workaround to make smoke-test pass. #3531

merged 1 commit into from
Mar 15, 2022

Conversation

yifanyang
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (05b5184) to 76.17% (a94b729) by ?.

    32 individual files with coverage change

    FilenameBase (05b5184)Merge (a94b729)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?73.44%?
    AppDistributionRelease.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionRelease.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?67.86%?
    AutoValue_UpdateProgress.java?65.96%?
    BinaryType.java?100.00%?
    FirebaseAppDistribution.java?94.58%?
    FirebaseAppDistributionException.java?84.85%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?73.68%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?90.91%?
    FirebaseAppDistributionTesterApiClient.java?91.40%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?64.71%?
    NewReleaseFetcher.java?87.95%?
    OnProgressListener.java?0.00%?
    ReleaseIdentificationUtils.java?15.52%?
    ReleaseUtils.java?76.92%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?57.14%?
    TaskUtils.java?92.86%?
    TesterSignInManager.java?93.68%?
    UpdateProgress.java?100.00%?
    UpdateStatus.java?100.00%?
    UpdateTask.java?100.00%?
    UpdateTaskImpl.java?82.81%?

  • firebase-database

    Overall coverage changed from 50.18% (05b5184) to 50.24% (a94b729) by +0.05%.

    FilenameBase (05b5184)Merge (a94b729)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    QueryParams.java89.76%90.36%+0.60%

  • firebase-firestore

    Overall coverage changed from 45.63% (05b5184) to 45.64% (a94b729) by +0.01%.

    FilenameBase (05b5184)Merge (a94b729)Diff
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.29%97.14%+2.86%

  • firebase-storage

    Overall coverage changed from 85.89% (05b5184) to 85.85% (a94b729) by -0.04%.

    FilenameBase (05b5184)Merge (a94b729)Diff
    UploadTask.java80.94%80.58%-0.36%

Test Logs

Notes

  • Commit (a94b729) is created by Prow via merging PR base commit (05b5184) and head commit (355b46d).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WOLlFF8gwZ.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (05b5184) and merge commit (a94b729).

Test Logs

Notes

  • Commit (a94b729) is created by Prow via merging PR base commit (05b5184) and head commit (355b46d).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CePCiEAIVa.html

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 355b46d link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dconeybe added a commit that referenced this pull request Mar 15, 2022
@dconeybe
Cherry-pick #3531 to fix the `More than one file was found with OS in…
f141041 
…dependent path META-INF/DEPENDENCIES` build error
@dconeybe dconeybe self-assigned this Mar 15, 2022
@dconeybe
Copy link
Contributor

I'm testing out this fix by cherry-picking it into the problematic PR: #3518. I'll approve if it fixes it.

@dconeybe
Copy link
Contributor

I'm testing out this fix by cherry-picking it into the problematic PR: #3518. I'll approve if it fixes it.

Confirmed that it fixes smoke-tests.

@dconeybe dconeybe assigned yifanyang and unassigned dconeybe Mar 15, 2022
dconeybe added a commit that referenced this pull request Mar 15, 2022
@dconeybe
Revert "Cherry-pick #3531 to fix the `More than one file was found wi…
27f648f 
…th OS independent path META-INF/DEPENDENCIES` build error"

This reverts commit f141041.
@yifanyang yifanyang merged commit 2bf81a5 into master Mar 15, 2022
@yifanyang yifanyang deleted the yifany/smoke-test branch March 15, 2022 03:22
yifanyang added a commit that referenced this pull request Mar 16, 2022
@yifanyang
Revert "[firehorn] Workaround to make smoke-test pass. (#3531)"
3b1a68c 
This reverts commit 2bf81a5.
yifanyang added a commit that referenced this pull request Mar 18, 2022
@yifanyang
Revert "[firehorn] Workaround to make smoke-test pass. (#3531)"
2df869a 
This reverts commit 2bf81a5.
@yifanyang yifanyang mentioned this pull request Mar 24, 2022
Merged
yifanyang added a commit that referenced this pull request Mar 24, 2022
@yifanyang
[firehorn] Revert "Workaround to make smoke-test pass. (#3531)" (#3543)
10fb9b2
jeremyjiang-dev pushed a commit that referenced this pull request Mar 24, 2022
@yifanyang @jeremyjiang-dev
[firehorn] Revert "Workaround to make smoke-test pass. (#3531)" (#3543)
81eb629
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@yifanyang @jeremyjiang-dev
[firehorn] Revert "Workaround to make smoke-test pass. (#3531)" (#3543)
38d4d5d
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@yifanyang @jeremyjiang-dev
[firehorn] Revert "Workaround to make smoke-test pass. (#3531)" (#3543)
266c2ce
jeremyjiang-dev pushed a commit that referenced this pull request Mar 25, 2022
@yifanyang @jeremyjiang-dev
[firehorn] Revert "Workaround to make smoke-test pass. (#3531)" (#3543)
15dd6de
@firebase firebase locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees

@yifanyang yifanyang

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yifanyang @google-oss-bot @dconeybe