Skip to content

Support encoding and decoding Composite Filters. #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2022
Merged

Support encoding and decoding Composite Filters. #3339

merged 3 commits into from
Feb 3, 2022

Conversation

ehsannas
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 21, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.34% (ccd1cb6) to 45.43% (f925572) by +0.09%.

    FilenameBase (ccd1cb6)Merge (f925572)Diff
    CompositeFilter.java0.00%35.00%+35.00%
    DeleteMutation.java90.00%95.00%+5.00%
    PatchMutation.java98.39%100.00%+1.61%
    RemoteSerializer.java84.63%84.78%+0.14%
    SetMutation.java94.29%97.14%+2.86%
    StructuredQuery.java32.44%32.52%+0.08%

Test Logs

Notes

  • Commit (f925572) is created by Prow via merging PR base commit (ccd1cb6) and head commit (49ab0b3).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JteV0Fc1iY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 21, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ccd1cb6)Merge (f925572)Diff
    aar1.24 MB1.24 MB+467 B (+0.0%)
    apk (release)3.33 MB3.33 MB+644 B (+0.0%)

Test Logs

Notes

  • Commit (f925572) is created by Prow via merging PR base commit (ccd1cb6) and head commit (49ab0b3).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hGlK0mxsdT.html

schmidt-sebastian
schmidt-sebastian reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - can you also add a test to https://github.com/firebase/firebase-android-sdk/blob/master/firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalSerializerTest.java#L401 ?

ehsannas
ehsannas commented Jan 26, 2022
View reviewed changes
Copy link
Contributor Author

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added equals (and hashCode) which was needed to be able to correctly compare results of encode/decode in tests. PTAL.

@ehsannas
Copy link
Contributor Author

/retest

schmidt-sebastian
schmidt-sebastian approved these changes Jan 26, 2022
View reviewed changes
@ehsannas ehsannas merged commit 53ff022 into master Feb 3, 2022
@ehsannas ehsannas deleted the ehsann/or-queries-pr-3 branch February 3, 2022 18:30
@firebase firebase locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@ehsannas ehsannas

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian