Skip to content

Add Overlay class #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add Overlay class #3329

merged 1 commit into from
Jan 19, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

Splitting up #3323. This is the first PR.

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/overlaychanges branch 2 times, most recently from 789d081 to d5149b4 Compare January 19, 2022 20:51
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 19, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.27% (5cf9ae8) to 45.25% (3b0a946) by -0.02%.

    FilenameBase (5cf9ae8)Merge (3b0a946)Diff
    AutoValue_Overlay.java?31.82%?
    DeleteMutation.java95.00%90.00%-5.00%
    Overlay.java?100.00%?
    PatchMutation.java100.00%98.39%-1.61%
    SQLiteDocumentOverlayCache.java90.91%95.00%+4.09%

Test Logs

Notes

  • Commit (3b0a946) is created by Prow via merging PR base commit (5cf9ae8) and head commit (9d64048).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IDPhw41r30.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 19, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (5cf9ae8)Merge (3b0a946)Diff
    aar1.23 MB1.23 MB+1.29 kB (+0.1%)
    apk (release)3.33 MB3.33 MB+560 B (+0.0%)

Test Logs

Notes

  • Commit (3b0a946) is created by Prow via merging PR base commit (5cf9ae8) and head commit (9d64048).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GeKHeG69ei.html

thebrianchen
thebrianchen approved these changes Jan 19, 2022
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is similar to what I have here. lgtm, thanks!

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 9d64048 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian
Copy link
Contributor Author

Sorry I wanted to get my other PR out. Should have checked with you beforehand.

@schmidt-sebastian schmidt-sebastian merged commit 20fe010 into master Jan 19, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/overlaychanges branch January 19, 2022 21:45
@firebase firebase locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @thebrianchen