Skip to content

Fad only show UI for basic config #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 4, 2022
Merged

Fad only show UI for basic config #3260

merged 11 commits into from
Jan 4, 2022

Conversation

rachaprince
Copy link

@rachaprince rachaprince commented Dec 21, 2021 •
edited
Loading

  • SignIn Dialog now only shows for the updatetonewreleaseifavailable method

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 21, 2021 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-app-distribution

    Overall coverage changed from 70.24% (6178b13) to 69.59% (7ab875a) by -0.66%.

    FilenameBase (6178b13)Merge (7ab875a)Diff
    FirebaseAppDistribution.java88.96%89.82%+0.86%
    FirebaseAppDistributionException.java86.67%87.10%+0.43%
    TesterSignInManager.java87.93%84.62%-3.32%
    UpdateTaskImpl.java84.38%82.81%-1.56%

Test Logs

Notes

  • Commit (7ab875a) is created by Prow via merging PR base commit (6178b13) and head commit (615944d).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KpeJJsG9RI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 21, 2021 •
edited
Loading

Size Report 1

Affected Products

  • firebase-app-distribution

    TypeBase (6178b13)Merge (7ab875a)Diff
    aar120 kB120 kB-466 B (-0.4%)
    apk (aggressive)739 kB739 kB-16 B (-0.0%)
    apk (release)1.55 MB1.55 MB-260 B (-0.0%)

Test Logs

Notes

  • Commit (7ab875a) is created by Prow via merging PR base commit (6178b13) and head commit (615944d).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZK5RQx7bsC.html

lfkellogg
lfkellogg reviewed Dec 22, 2021
View reviewed changes
manny-jimenez
manny-jimenez reviewed Dec 23, 2021
View reviewed changes
...distribution/src/main/java/com/google/firebase/app/distribution/FirebaseAppDistribution.java Outdated
showDialogTask.setException(
new FirebaseAppDistributionException(
ErrorMessages.APP_BACKGROUNDED,
FirebaseAppDistributionException.Status.UPDATE_NOT_AVAILABLE));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are scenarios like this where the status doesn't exactly align with what is going on (here its not that an update isn't available). Our logs do have the more specific case to give the user a better sense of whats going on, but do we want to look at these statuses to make them more specific?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good call. I've added an error message enum to our API and made a note to add it to the API addendum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, good callout. There are a bunch of places like this where the error status and/or message does not align with the actual situation. I'm currently going through them all as part of the error handling cleanup, so @rachaprince if you want I can handle this in a followup since this was just moved code.

For this case though, looking at the statuses, AUTHENTICATION_FAILED might work if we consider "authentication" to be synonymous with "tester sign in."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think your new "no foreground activity" error seems like a good one to add, could be useful elsewhere. AUTHENTICATION_FAILED probably implies that the actual authentication was not allowed, which would be misleading.

rachaprince
rachaprince commented Dec 23, 2021
View reviewed changes
...distribution/src/main/java/com/google/firebase/app/distribution/FirebaseAppDistribution.java Outdated
showDialogTask.setException(
new FirebaseAppDistributionException(
ErrorMessages.APP_BACKGROUNDED,
FirebaseAppDistributionException.Status.UPDATE_NOT_AVAILABLE));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good call. I've added an error message enum to our API and made a note to add it to the API addendum.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-app-distribution:
error: Added enum constant com.google.firebase.app.distribution.FirebaseAppDistributionException.Status.FOREGROUND_ACTIVITY_NOT_AVAILABLE [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

lfkellogg
lfkellogg reviewed Dec 23, 2021
View reviewed changes
...distribution/src/main/java/com/google/firebase/app/distribution/FirebaseAppDistribution.java Outdated
showDialogTask.setException(
new FirebaseAppDistributionException(
ErrorMessages.APP_BACKGROUNDED,
FirebaseAppDistributionException.Status.UPDATE_NOT_AVAILABLE));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, good callout. There are a bunch of places like this where the error status and/or message does not align with the actual situation. I'm currently going through them all as part of the error handling cleanup, so @rachaprince if you want I can handle this in a followup since this was just moved code.

For this case though, looking at the statuses, AUTHENTICATION_FAILED might work if we consider "authentication" to be synonymous with "tester sign in."

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-app-distribution:
error: Added enum constant com.google.firebase.app.distribution.FirebaseAppDistributionException.Status.FOREGROUND_ACTIVITY_NOT_AVAILABLE [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

lfkellogg
lfkellogg reviewed Dec 23, 2021
View reviewed changes
...distribution/src/main/java/com/google/firebase/app/distribution/FirebaseAppDistribution.java Outdated
showDialogTask.setException(
new FirebaseAppDistributionException(
ErrorMessages.APP_BACKGROUNDED,
FirebaseAppDistributionException.Status.UPDATE_NOT_AVAILABLE));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think your new "no foreground activity" error seems like a good one to add, could be useful elsewhere. AUTHENTICATION_FAILED probably implies that the actual authentication was not allowed, which would be misleading.

@lfkellogg
Copy link
Contributor

Looks like you just need to run ./gradlew :firebase-app-distribution:googleJavaFormat

@rachaprince rachaprince merged commit fea8375 into master Jan 4, 2022
@rachaprince rachaprince deleted the fad-only-show-ui-for-basic-config branch January 4, 2022 22:15
@firebase firebase locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfkellogg lfkellogg lfkellogg approved these changes

@manny-jimenez manny-jimenez manny-jimenez approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachaprince @google-oss-bot @lfkellogg @manny-jimenez