docs: improve documentation for merge behavior #3257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKsNo changes between base commit (15f59af) and head commit (0abdad03). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (0abdad03) is created by Prow via merging commits: 15f59af c070127. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (0abdad03) is created by Prow via merging commits: 15f59af c070127. |
thebrianchen
approved these changes
Dec 22, 2021
| @@ -59,7 +59,8 @@ public FieldMask getFieldMask() { | |||
|
|
|||
| /** | |||
| * Changes the behavior of {@code set()} calls to only replace the values specified in its data | |||
| * argument. Fields omitted from the {@code set()} call will remain untouched. | |||
| * argument. Fields omitted from the {@code set()} call will remain untouched. If your input sets | |||
| * any field to an empty map, all nested fields at this location are overwritten. | |||
There was a problem hiding this comment.
I left it as is as it creates weird capitalization and should also really be a {@link Map}, which then is too generic to be useful.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses firebase/firebase-admin-node#987