Skip to content

Renaming from webclient review #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2018
Merged

Renaming from webclient review #31

merged 1 commit into from
Sep 19, 2018

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Sep 19, 2018

Doing some renaming that came up in the webclient review of part of the LRU port (firebase/firebase-js-sdk#1224)

No functional changes.

@gsoltis gsoltis requested a review from mikelehen September 19, 2018 20:31
mikelehen
mikelehen approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mikelehen mikelehen assigned gsoltis and unassigned mikelehen Sep 19, 2018
@gsoltis gsoltis merged commit 351df0e into master Sep 19, 2018
@gsoltis gsoltis deleted the gsoltis/in_memory_pins branch September 19, 2018 20:51
@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@gsoltis gsoltis

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsoltis @mikelehen @google-oss-bot