Clean up old sessions in the NDK #2680
Conversation
Coverage ReportAffected SDKsNo changes between base commit (6357bbe) and head commit (a82bf936). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (a82bf936) is created by Prow via merging commits: 6357bbe 4271933. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (a82bf936) is created by Prow via merging commits: 6357bbe 4271933. |
| recursiveDelete(new File(rootPath, sessionId)); | ||
| } | ||
|
|
||
| @Override | ||
| public void cleanOldSessionFileDirectories() { | ||
| File[] sessionFileDirectories = rootPath.listFiles(File::isDirectory); |
There was a problem hiding this comment.
I'd double check with Marc about JDK version requirements - this syntax may not be supported.
There was a problem hiding this comment.
It should work now that we're requiring everyone to update to Java 8 (as of the M95 release). I think this syntax is 100% resolved in the compiler but it is probably worth testing on an API 19 emulator, which I believe is the oldest we support.
There was a problem hiding this comment.
Correction: API 16 is the oldest one we support.
There was a problem hiding this comment.
I tested it on an emulator with API 16 and it works fine. We use this syntax in a few other places already.
|
/test macrobenchmark |
Clean up old sessions in the NDK before initializing and after finalizing a session.
Tested manually with a test app.