Add a tools:remove rule to the discovery service definition. #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removal is needed to satisfy the manifest merger when it merges manifests across dynamic feature modules into the base app. Since each Firebase SDK has a discovery service definition in its manifest, placing them into a dynamic feature adds `android:splitName="featureName"` to the discovery service. Subsequent merge into the main app manifest causes a conflict since the splitName is different in each feature. Note that this change is also moving the dynamic module support registrar definition to `firebase-dynamic-module-support` since having an `android:remove` in `firebase-common` produces a warning when the app does not use dynamic feature modules. To avoid this warning, the manifest entry will now live in the dynamic module support sdk, since it's only expected to be used if the host app uses dynamic features. http://b/184263558
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (3351a919) is created by Prow via merging commits: 0a5b6ba a1a89d9. |
Coverage ReportAffected SDKsNo changes between base commit (0a5b6ba) and head commit (3351a919). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (3351a919) is created by Prow via merging commits: 0a5b6ba a1a89d9. |
|
/retest |
|
@vkryachko: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rlazo
approved these changes
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal is needed to satisfy the manifest merger when it merges
manifests across dynamic feature modules into the base app.
Since each Firebase SDK has a discovery service definition in its
manifest, placing them into a dynamic feature adds
android:splitName="featureName"to the discovery service. Subsequentmerge into the main app manifest causes a conflict since the splitName
is different in each feature.
Note that this change is also moving the dynamic module support
registrar definition to
firebase-dynamic-module-supportsince havingan
android:removeinfirebase-commonproduces a warning when the appdoes not use dynamic feature modules. To avoid this warning, the
manifest entry will now live in the dynamic module support sdk, since
it's only expected to be used if the host app uses dynamic features.
http://b/184263558