Fix personalization test and add check for optionalProvider. #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (1e52d552) is created by Prow via merging commits: 0a5b6ba c82ba25. |
Binary Size ReportAffected SDKsNo changes between base commit (0a5b6ba) and head commit (1e52d552). Test Logs
NotesHead commit (1e52d552) is created by Prow via merging commits: 0a5b6ba c82ba25. |
vkryachko
reviewed
Apr 1, 2021
firebase-config/src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigTest.java
Show resolved
Hide resolved
|
/test check-changed |
1 similar comment
|
/test check-changed |
Flake |
vkryachko
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
LGTM, but let's wait for @danasilver to review before merging.
|
SGTM |
danasilver
approved these changes
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The personalization test was using the default namespace, and because another instance of config already existed in that namespace, the test instance was not being created. This caused the personalization test to try to use real objects instead of the mocks, including the direct executor. This PR fixes this and uses a provider to fake the interaction when Analytics is present and when it's not.