Skip to content

Updating variable names from the test classes to follow Java's code convention (b/177441811) #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 25, 2021
Merged

Updating variable names from the test classes to follow Java's code convention (b/177441811) #2546

merged 6 commits into from
Mar 25, 2021

Conversation

ramanpreetSinghKhinda
Copy link
Contributor

What this PR entails?

  • Refer b/177441811 for more details.
  • This PR is only for updating test classes and not the source classes.

How to review this PR?

  • Look at the class level variable names and if that looks good to you then just move on to other class. Reason being the rest of the changes in the class are most likely the name refactoring change which are automatically done by the AndroidRefactoring tool and thus I don't expect any issues there.

Is this an exhaustive change?

  • Not necessarily but this is a good first step to build upon. There could be many different ways of declaring variable names but I chose the one which is easy to follow IMHO.
  • Also there's so much more to improve on but I decided to just update class level variable names

@googlebot googlebot added the cla: yes Override cla label Mar 25, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-perf

    SDK overall coverage changed from ? (23fc235) to 70.50% (80ce45c0) by ?.

    Click to show coverage changes in 95 files.
    Filename Base (23fc235) Head (80ce45c0) Diff
    AddTrace.java ? 0.00% ?
    AndroidApplicationInfo.java ? 34.71% ?
    AndroidApplicationInfoOrBuilder.java ? 0.00% ?
    AndroidLogger.java ? 97.78% ?
    AndroidMemoryReading.java ? 38.36% ?
    AndroidMemoryReadingOrBuilder.java ? 0.00% ?
    AppStartTrace.java ? 82.65% ?
    AppStateMonitor.java ? 84.66% ?
    AppStateUpdateHandler.java ? 92.59% ?
    ApplicationInfo.java ? 45.00% ?
    ApplicationInfoOrBuilder.java ? 0.00% ?
    ApplicationProcessState.java ? 73.91% ?
    Clock.java ? 100.00% ?
    ConfigResolver.java ? 97.23% ?
    ConfigurationConstants.java ? 99.21% ?
    ConfigurationFlag.java ? 100.00% ?
    Constants.java ? 95.65% ?
    Counter.java ? 90.91% ?
    CpuGaugeCollector.java ? 93.10% ?
    CpuMetricReading.java ? 39.33% ?
    CpuMetricReadingOrBuilder.java ? 0.00% ?
    DaggerFirebasePerformanceComponent.java ? 100.00% ?
    DeviceCacheManager.java ? 76.03% ?
    FirebasePerfApplicationInfoValidator.java ? 92.86% ?
    FirebasePerfGaugeMetricValidator.java ? 100.00% ?
    FirebasePerfHttpClient.java ? 93.85% ?
    FirebasePerfMetricProto.java ? 0.00% ?
    FirebasePerfNetworkValidator.java ? 86.81% ?
    FirebasePerfOkHttpClient.java ? 44.90% ?
    FirebasePerfProvider.java ? 76.92% ?
    FirebasePerfRegistrar.java ? 100.00% ?
    FirebasePerfTraceValidator.java ? 88.24% ?
    FirebasePerfUrlConnection.java ? 44.26% ?
    FirebasePerformance.java ? 82.95% ?
    FirebasePerformanceAttributable.java ? 0.00% ?
    FirebasePerformanceComponent.java ? 0.00% ?
    FirebasePerformanceInitializer.java ? 33.33% ?
    FirebasePerformanceModule.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesGaugeManagerFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java ? 100.00% ?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java ? 100.00% ?
    FirebasePerformance_Factory.java ? 100.00% ?
    FlgTransport.java ? 83.33% ?
    GaugeManager.java ? 98.39% ?
    GaugeMetadata.java ? 32.21% ?
    GaugeMetadataManager.java ? 84.62% ?
    GaugeMetadataOrBuilder.java ? 0.00% ?
    GaugeMetric.java ? 39.47% ?
    GaugeMetricOrBuilder.java ? 0.00% ?
    HttpMetric.java ? 91.78% ?
    ImmutableBundle.java ? 100.00% ?
    InstrHttpInputStream.java ? 92.86% ?
    InstrHttpOutputStream.java ? 98.00% ?
    InstrHttpURLConnection.java ? 93.42% ?
    InstrHttpsURLConnection.java ? 94.32% ?
    InstrURLConnectionBase.java ? 95.22% ?
    InstrumentApacheHttpResponseHandler.java ? 100.00% ?
    InstrumentOkHttpEnqueueCallback.java ? 100.00% ?
    LogWrapper.java ? 23.08% ?
    MemoryGaugeCollector.java ? 90.00% ?
    NetworkConnectionInfo.java ? 0.00% ?
    NetworkConnectionInfoOrBuilder.java ? 0.00% ?
    NetworkRequestMetric.java ? 49.16% ?
    NetworkRequestMetricBuilder.java ? 96.00% ?
    NetworkRequestMetricBuilderUtil.java ? 75.00% ?
    NetworkRequestMetricOrBuilder.java ? 0.00% ?
    Optional.java ? 86.67% ?
    PendingPerfEvent.java ? 100.00% ?
    PerfMetric.java ? 33.67% ?
    PerfMetricOrBuilder.java ? 0.00% ?
    PerfMetricValidator.java ? 90.32% ?
    PerfSession.java ? 93.33% ?
    PerfSessionOrBuilder.java ? 0.00% ?
    RateLimiter.java ? 90.27% ?
    RemoteConfigManager.java ? 92.24% ?
    ResourceType.java ? 0.00% ?
    SessionAwareObject.java ? 0.00% ?
    SessionManager.java ? 100.00% ?
    SessionVerbosity.java ? 68.42% ?
    StorageUnit.java ? 57.89% ?
    Timer.java ? 93.75% ?
    Trace.java ? 96.69% ?
    TraceMetric.java ? 43.42% ?
    TraceMetricBuilder.java ? 100.00% ?
    TraceMetricOrBuilder.java ? 0.00% ?
    TransportInfo.java ? 0.00% ?
    TransportInfoOrBuilder.java ? 0.00% ?
    TransportManager.java ? 94.09% ?
    URLAllowlist.java ? 94.44% ?
    URLWrapper.java ? 0.00% ?
    Utils.java ? 78.57% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (80ce45c0) is created by Prow via merging commits: 23fc235 53780bd.

@ramanpreetSinghKhinda
Updating "networkRequestBuilder" to "networkMetricBuilder" to align w…
3b1990c 
…ith "perfMetricBuilder" and "traceMetricBuilder"
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 25, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (23fc235) and head commit (80ce45c0).

Test Logs

Notes

Head commit (80ce45c0) is created by Prow via merging commits: 23fc235 53780bd.

@ramanpreetSinghKhinda ramanpreetSinghKhinda merged commit ff551e5 into master Mar 25, 2021
@ramanpreetSinghKhinda ramanpreetSinghKhinda deleted the perf-variables-tests branch March 25, 2021 19:44
ramanpreetSinghKhinda added a commit that referenced this pull request Mar 25, 2021
@ramanpreetSinghKhinda
Merging from Master. Also fixing the merge issues with #2546
aea12a4
@ramanpreetSinghKhinda
Copy link
Contributor Author

ramanpreetSinghKhinda commented Mar 25, 2021 •
edited
Loading

This PR created a few conflicts (like did not merged well and omitted some changes from the recently submitted PR #2518) when merging to Master. This has been resolved in #2545.

This was referenced Mar 25, 2021
Merged
Merged
@firebase firebase locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

@visumickey visumickey Awaiting requested review from visumickey

Assignees
No one assigned
Labels
cla: yes Override cla size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramanpreetSinghKhinda @google-oss-bot @jeremyjiang-dev @googlebot