Skip to content

b/80200799: Automatically log warnings for errors that likely represent developer mistakes / oversights. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2018
Merged

b/80200799: Automatically log warnings for errors that likely represent developer mistakes / oversights. #24

merged 2 commits into from
Sep 19, 2018

Conversation

mikelehen
Copy link
Contributor

@mikelehen mikelehen commented Sep 18, 2018 •
edited
Loading

@wilhuff What do you think about this? If you have any concerns, we can discuss at API discussion or whatever.

@mikelehen mikelehen requested a review from wilhuff September 18, 2018 01:08
wilhuff
wilhuff approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@mikelehen
Copy link
Contributor Author

/test connected-check

@mikelehen mikelehen merged commit c87bbb2 into master Sep 19, 2018
@mikelehen mikelehen deleted the mikelehen/log-errors branch September 19, 2018 00:10
@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

@thatfiredev thatfiredev thatfiredev approved these changes

Assignees

@wilhuff wilhuff

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikelehen @wilhuff @thatfiredev @google-oss-bot