Skip to content

Remove unused baseDoc argument #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

Remove unused baseDoc argument #2340

merged 1 commit into from
Jan 20, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jan 19, 2021 •
edited
Loading

Port from iOS firebase/firebase-ios-sdk#7276

This likely needs to be ported to Web too (but I didn't check - just worked on this while verifying the iOS PR).

@googlebot googlebot added the cla: yes Override cla label Jan 19, 2021
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 47.11% (2c088d7) to 47.11% (ed8b1bdf) by -0.01%.

    Filename Base (2c088d7) Head (ed8b1bdf) Diff
    MutationBatch.java 89.71% 89.55% -0.15%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (ed8b1bdf) is created by Prow via merging commits: 2c088d7 ec42a19.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (2c088d7) Head (ed8b1bdf) Diff
    aar 1.04 MB 1.04 MB -208 B (-0.0%)
    apk (release) 3.16 MB 3.16 MB -20 B (-0.0%)

Test Logs

Notes

Head commit (ed8b1bdf) is created by Prow via merging commits: 2c088d7 ec42a19.

thebrianchen
thebrianchen approved these changes Jan 20, 2021
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for doing this instead of me :)

firebase-firestore/src/main/java/com/google/firebase/firestore/model/mutation/Mutation.java
@@ -164,12 +162,12 @@ static SnapshotVersion getPostMutationVersion(@Nullable MaybeDocument maybeDoc)
* result of applying a transform) for use after a mutation containing transforms has been
* acknowledged by the server.
*
* @param baseDoc The document prior to applying this mutation batch.
* @param maybeDoc The current state of the document after applying all previous mutations.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the rename. Will port this to the iOS PR as well.

@schmidt-sebastian schmidt-sebastian merged commit 4370f77 into master Jan 20, 2021
@thebrianchen thebrianchen deleted the mrschmidt/basedoc branch January 21, 2021 01:34
@thebrianchen thebrianchen restored the mrschmidt/basedoc branch January 21, 2021 01:34
@thebrianchen thebrianchen mentioned this pull request Jan 29, 2021
Merged
andreaowu pushed a commit that referenced this pull request Jan 29, 2021
@schmidt-sebastian @andreaowu
Remove unused baseDoc argument (#2340)
564908a 
Port from iOS firebase/firebase-ios-sdk#7276
@firebase firebase locked and limited conversation to collaborators Feb 19, 2021
@kaibolay kaibolay deleted the mrschmidt/basedoc branch September 15, 2022 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @google-oss-bot @thebrianchen @googlebot