Skip to content

Catch null on queryIntentServices to fix NPE #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

Catch null on queryIntentServices to fix NPE #2263

merged 1 commit into from
Dec 16, 2020

Conversation

prakhar1989
Copy link
Contributor

@prakhar1989 prakhar1989 commented Dec 16, 2020 •
edited
Loading

image

@google-cla google-cla bot added the cla: yes Override cla label Dec 16, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (86b04aa) and head commit (849ee72a).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (849ee72a) is created by Prow via merging commits: 86b04aa 1770235.

@google-oss-bot
Copy link
Contributor

@prakhar1989: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 1770235 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-inappmessaging-display

    Type Base (86b04aa) Head (849ee72a) Diff
    aar 204 kB 204 kB +6 B (+0.0%)
    apk (aggressive) 1.43 MB 1.43 MB +100 B (+0.0%)
    apk (release) 4.54 MB 4.54 MB -120 B (-0.0%)

Test Logs

Notes

Head commit (849ee72a) is created by Prow via merging commits: 86b04aa 1770235.

eldhosembabu
eldhosembabu approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@eldhosembabu eldhosembabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakhar1989 prakhar1989 merged commit ee74cd0 into master Dec 16, 2020
@prakhar1989 prakhar1989 deleted the fix-NPE-on-queryIntentServices branch December 16, 2020 18:33
@eldhosembabu eldhosembabu mentioned this pull request Dec 17, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JasonAHeron JasonAHeron JasonAHeron approved these changes

@eldhosembabu eldhosembabu eldhosembabu approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prakhar1989 @google-oss-bot @JasonAHeron @eldhosembabu