Skip to content

Add development_platform for Unity crash reports #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

mrichards
Copy link
Contributor

@mrichards mrichards commented Oct 27, 2020

Crashlytics reports sent via DataTransport erroneously did not set the
development_platform field for Unity apps. This results in incorrect
internal metrics for Unity apps. b/171214452

Crashlytics reports sent via DataTransport erroneously did not set the
development_platform field for Unity apps. This results in incorrect
internal metrics for Unity apps.
@mrichards mrichards requested a review from mrwillis21 October 27, 2020 13:58
@googlebot googlebot added the cla: yes Override cla label Oct 27, 2020
@mrichards
Copy link
Contributor Author

@mrwillis21 I'm looking for feedback on the overall approach, and if you think it is worth adding in the install_source field in a similar way.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2020

Coverage Report

Affected SDKs

No changes between base commit (51c995e) and head commit (3887d9f8).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (3887d9f8) is created by Prow via merging commits: 51c995e f9e632a.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2020

Binary Size Report

Affected SDKs

  • firebase-crashlytics

    Type Base (51c995e) Head (3887d9f8) Diff
    aar 411 kB 412 kB +1.05 kB (+0.3%)
    apk (aggressive) 326 kB 326 kB +296 B (+0.1%)
    apk (release) 1.04 MB 1.04 MB +292 B (+0.0%)
  • firebase-installations

    Type Base (51c995e) Head (3887d9f8) Diff
    aar 62.0 kB 62.0 kB -4 B (-0.0%)

Test Logs

Notes

Head commit (3887d9f8) is created by Prow via merging commits: 51c995e f9e632a.

Copy link
Contributor

@mrwillis21 mrwillis21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, but otherwise this seems great to me.

@mrichards
Copy link
Contributor Author

/retest

@google-oss-bot
Copy link
Contributor

@mrichards: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests f9e632a link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrichards mrichards merged commit 44b4ccd into master Oct 27, 2020
@mrichards mrichards deleted the crashlytics-dev-platform-fix branch October 27, 2020 20:15
@firebase firebase locked and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants