-
Notifications
You must be signed in to change notification settings - Fork 617
Add development_platform for Unity crash reports #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Crashlytics reports sent via DataTransport erroneously did not set the development_platform field for Unity apps. This results in incorrect internal metrics for Unity apps.
@mrwillis21 I'm looking for feedback on the overall approach, and if you think it is worth adding in the install_source field in a similar way. |
Coverage ReportAffected SDKsNo changes between base commit (51c995e) and head commit (3887d9f8). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (3887d9f8) is created by Prow via merging commits: 51c995e f9e632a. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (3887d9f8) is created by Prow via merging commits: 51c995e f9e632a. |
.../main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsReportDataCapture.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, but otherwise this seems great to me.
/retest |
@mrichards: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Crashlytics reports sent via DataTransport erroneously did not set the
development_platform field for Unity apps. This results in incorrect
internal metrics for Unity apps. b/171214452