Add custom domain support to callable functions

[kroikie]

Discussion

Googlers: see API review here

Testing

• Added new unit tests

API Changes

• API reviewed

This change is in line with other similar changes for JS and iOS sdk:
JS implemented
iOS implemented

[google-oss-bot]

Coverage Report

Affected SDKs

• firebase-functions

  SDK overall coverage changed from 3.69% (9a8cd2c) to 3.59% (e9ab0ec9) by -0.10%.

  Filename	Base (9a8cd2c)	Head (e9ab0ec9)	Diff

Test Logs

• Base (9a8cd2c7): https://android-ci.firebaseopensource.com/view/gcs/android-ci/logs/postsubmit-check-coverage/1320831227778830338
• Head (e9ab0ec9): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/2100/check-coverage-changed/1321121644713873414

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e9ab0ec9) is created by Prow via merging commits: 9a8cd2c bc0e438.

[kroikie]

This PR combines the region and custom domain in a single regionOrCustomDomain FirebaseFunctions constructor parameter. This parameter is checked for being a valid URL, this check is done using the Apache commons UrlValidator. This option provided a clean way of checking if regionOrCustomDomain was a valid URL or not.

If adding this dependency is an issue there are other options that I would be happy to switch to:

1. Try to create a URL and catch the resulting exception (like done in the JS implementation)
2. Use a RegEx to see if the parameter is a URL or not
3. Check if the parameter starts with http or https since no region will have this prefix

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase-common

  Type	Base (9a8cd2c)	Head (e9ab0ec9)	Diff
  aar	?	36.1 kB	? (?)
  apk (aggressive)	?	74.5 kB	? (?)
  apk (release)	?	627 kB	? (?)

• firebase-common-ktx

  Type	Base (9a8cd2c)	Head (e9ab0ec9)	Diff
  aar	?	5.98 kB	? (?)
  apk (aggressive)	?	90.2 kB	? (?)
  apk (release)	?	1.10 MB	? (?)

• firebase-components

  Type	Base (9a8cd2c)	Head (e9ab0ec9)	Diff
  aar	?	34.7 kB	? (?)
  apk (aggressive)	?	8.68 kB	? (?)
  apk (release)	?	25.2 kB	? (?)

• firebase-functions

  Type	Base (9a8cd2c)	Head (e9ab0ec9)	Diff
  aar	?	26.4 kB	? (?)
  apk (aggressive)	?	347 kB	? (?)
  apk (release)	?	1.16 MB	? (?)

• firebase-functions-ktx

  Type	Base (9a8cd2c)	Head (e9ab0ec9)	Diff
  aar	?	5.86 kB	? (?)
  apk (aggressive)	?	367 kB	? (?)
  apk (release)	?	1.64 MB	? (?)

Test Logs

• Head (e9ab0ec9): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/2100/binary-size/1321121644713873413

Notes

Head commit (e9ab0ec9) is created by Prow via merging commits: 9a8cd2c bc0e438.

[kroikie]

@samtstern looks like the smoke test has an issue with ML:

Could not find com.google.firebase:firebase-ml-natural-language

[samtstern]

@kroikie LGTM I don't think the smoke test thing is your fault but hopefully someone else can chime in.

[google-oss-bot]

@kroikie: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
smoke-tests	bc0e438	link	/test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.