Skip to content

Query get API for RTDB #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 13, 2020
Merged

Query get API for RTDB #2087

merged 10 commits into from
Nov 13, 2020

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Oct 21, 2020 •
edited by schmidt-sebastian
Loading

@googlebot googlebot added the cla: yes Override cla label Oct 21, 2020
@google-cla google-cla bot added the cla: yes Override cla label Oct 21, 2020
@jmwski
Copy link
Contributor Author

jmwski commented Oct 21, 2020

@schmidt-sebastian Can you take a quick pass over this to check implementation strategy?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 21, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.99% (c7f1620) to 50.30% (27df67d8) by -0.68%.

    Filename Base (c7f1620) Head (27df67d8) Diff
    ChildChangeAccumulator.java 96.67% 83.33% -13.33%
    PersistentConnectionImpl.java 17.92% 16.34% -1.58%
    Query.java 50.00% 49.70% -0.30%
    Repo.java 10.88% 10.34% -0.54%
    SyncTree.java 64.57% 62.99% -1.58%
    ViewProcessor.java 91.79% 92.10% +0.30%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (27df67d8) is created by Prow via merging commits: c7f1620 7a8e352.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 21, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-database

    Type Base (c7f1620) Head (27df67d8) Diff
    aar 480 kB 490 kB +10.7 kB (+2.2%)
    apk (release) 1.08 MB 1.08 MB +2.30 kB (+0.2%)

Test Logs

Notes

Head commit (27df67d8) is created by Prow via merging commits: c7f1620 7a8e352.

@jmwski jmwski requested a review from jsdt October 22, 2020 18:25
schmidt-sebastian
schmidt-sebastian reviewed Oct 27, 2020
View reviewed changes
schmidt-sebastian
schmidt-sebastian reviewed Nov 3, 2020
View reviewed changes
@schmidt-sebastian schmidt-sebastian removed their assignment Nov 3, 2020
@jmwski jmwski assigned schmidt-sebastian and unassigned jmwski Nov 4, 2020
schmidt-sebastian
schmidt-sebastian reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks very nice!

@jmwski jmwski assigned schmidt-sebastian and unassigned jmwski Nov 12, 2020
@jmwski
Copy link
Contributor Author

jmwski commented Nov 12, 2020

/retest

@jmwski jmwski assigned schmidt-sebastian and Feiyang1 and unassigned jmwski Nov 13, 2020
@jmwski jmwski requested a review from Feiyang1 November 13, 2020 21:24
@jmwski jmwski removed the request for review from Feiyang1 November 13, 2020 21:32
@jmwski jmwski merged commit 9ebc35f into master Nov 13, 2020
@jmwski jmwski deleted the jw/rtdb-query-get branch November 13, 2020 21:32
@jmwski jmwski mentioned this pull request Dec 4, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@jsdt jsdt Awaiting requested review from jsdt

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: database cla: yes Override cla size/L WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmwski @google-oss-bot @schmidt-sebastian @Feiyang1 @googlebot