Skip to content

Add maven proxy configuration. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2018
Merged

Add maven proxy configuration. #20

merged 4 commits into from
Sep 17, 2018

Conversation

vkryachko
Copy link
Member

Fixes #12

@vkryachko
Copy link
Member Author

/retest

@vkryachko
Copy link
Member Author

/retest

ashwinraghav
ashwinraghav approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@ashwinraghav ashwinraghav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;tldr I think we should ship this, and keep an eye out.

The risks I see are that we have a cache that does not have a strict notion of the fact that it is caching maven artifacts, which might lead to some unexpected caveats in the future.

One area that bjornick@ mentioned that is worth exploring is to mount a shared directory for the maven cache with individual containers each having their own gradle cache. Something worth exploring if this does not work out reasonably.

@vkryachko
Copy link
Member Author

SG

One area that bjornick@ mentioned that is worth exploring is to mount a shared directory for the maven cache with individual containers each having their own gradle cache. Something worth exploring if this does not work out reasonably.

This is exactly the setup we have today and it still causes lock contention because multiple gradle processes try to populate the cache as they run. Also this approach relies on gradle's current cache directory layout which is not documented and afaik is not guaranteed to be stable.

@vkryachko vkryachko merged commit a4357b8 into master Sep 17, 2018
@vkryachko vkryachko deleted the vk.maven-proxy branch September 21, 2018 20:14
ashwinraghav added a commit that referenced this pull request Sep 28, 2018
@ashwinraghav
Revert "Add maven proxy configuration. (#20)"
64b9ee8 
This reverts commit a4357b8.
ashwinraghav added a commit that referenced this pull request Oct 2, 2018
@ashwinraghav
Revert "Add maven proxy configuration. (#20)" (#51)
41d6ce0
@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwinraghav ashwinraghav ashwinraghav approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails on gradle cache lock timeout.
3 participants
@vkryachko @ashwinraghav @google-oss-bot