Add INTERNET and ACCESS_NETWORK_STATE to database permissions. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
approved these changes
Sep 14, 2018
|
@mikelehen this will work, but I remember @schmidt-sebastian doing this exact same thing a few months ago. Starting to wonder if the import of code into this repo may have been slightly outdated? I have also seen two reports of NPEs just from calling |
schmidt-sebastian
approved these changes
Sep 17, 2018
|
FYI: I added these permission to the no longer existing |
|
/test connected-check |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what changed so that now this is necessary, but I assume this change will resolve #18. That said I haven't explicitly validated this as I'm not sure how.
cc/ @samtstern