Skip to content

Initialize Firebase in direct boot mode #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2020
Merged

Initialize Firebase in direct boot mode #1840

merged 2 commits into from
Aug 6, 2020

Conversation

vkryachko
Copy link
Member

@vkryachko vkryachko commented Jul 31, 2020 •
edited
Loading

Note that even though `FirebaseApp itself initializes, none of the other SDKs get initialized until the user unlocks the devices.
See #1766

@vkryachko
Initialize Firebase in direct boot mode
59cbb01 
Note that even though `FirebaseApp itself initializes, none of the other SDKs get initialized until the user unlocks the devices.
@vkryachko vkryachko requested a review from ashwinraghav July 31, 2020 14:36
@googlebot googlebot added the cla: yes Override cla label Jul 31, 2020
@vkryachko
Copy link
Member Author

@ashwinraghav you see any concerns with doing this?

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 31, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (975bb59) Head (8d29024b) Diff
    aar 35.3 kB 35.4 kB +134 B (+0.4%)
    apk (aggressive) 74.5 kB 74.6 kB +124 B (+0.2%)
    apk (release) 626 kB 627 kB +224 B (+0.0%)

Test Logs

Notes

Head commit (8d29024b) is created by Prow via merging commits: 975bb59 5567b2b.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 31, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-common

    SDK overall coverage changed from 44.28% (975bb59) to 44.21% (8d29024b) by -0.07%.

    Filename Base (975bb59) Head (8d29024b) Diff
    FirebaseApp.java 52.97% 52.68% -0.29%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8d29024b) is created by Prow via merging commits: 975bb59 5567b2b.

@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko merged commit 739dd16 into master Aug 6, 2020
@google-oss-bot
Copy link
Contributor

@vkryachko: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 5567b2b link /test check-changed
device-check-changed 5567b2b link /test device-check-changed
smoke-tests 5567b2b link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators Sep 6, 2020
@vkryachko vkryachko deleted the vk.app-directboot branch October 20, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @rlazo @googlebot