Skip to content

Improve kotlindoc rendering. #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Improve kotlindoc rendering. #1777

merged 1 commit into from
Jul 20, 2020

Conversation

vkryachko
Copy link
Member

Specifically allows SDKs to declare dependencies via javadocClasspath
configuration for the dokka run to make {@link} tags render properly.

Depends on https://android-review.googlesource.com/c/platform/external/dokka/+/1365296
for rendering to work correctly.

Specifically allows SDKs to declare dependencies via `javadocClasspath`
configuration for the dokka run to make `{@link}` tags render properly.

Depends on https://android-review.googlesource.com/c/platform/external/dokka/+/1365296
for rendering to work correctly.
@vkryachko vkryachko requested a review from rlazo July 16, 2020 19:24
@googlebot googlebot added the cla: yes Override cla label Jul 16, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 16, 2020

Binary Size Report

Affected SDKs

  • firebase-common-ktx

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 1.39 MB 1.39 MB -2 B (-0.0%)
  • firebase-components

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 35.2 kB 35.2 kB +2 B (+0.0%)
  • firebase-config-ktx

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 1.87 MB 1.87 MB -1 B (-0.0%)
  • firebase-crashlytics

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 1.28 MB 1.28 MB -2 B (-0.0%)
  • firebase-crashlytics-ktx

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 1.90 MB 1.90 MB -1 B (-0.0%)
  • firebase-crashlytics-ndk

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 2.76 MB 2.76 MB -4.10 kB (-0.1%)
  • firebase-database-ktx

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 1.92 MB 1.92 MB -1 B (-0.0%)
  • firebase-datatransport

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 856 kB 856 kB -3 B (-0.0%)
  • firebase-inappmessaging

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 4.13 MB 4.13 MB +1 B (+0.0%)
  • firebase-installations

    Type Base (37dd2b1) Head (d7087e0d) Diff
    aar 59.2 kB 59.2 kB +4 B (+0.0%)
  • transport-runtime

    Type Base (37dd2b1) Head (d7087e0d) Diff
    apk (debug) 82.5 kB 82.5 kB +1 B (+0.0%)

Test Logs

Notes

Head commit (d7087e0d) is created by Prow via merging commits: 37dd2b1 0c1ca6f.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 16, 2020

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 49.95% (37dd2b1) to 49.98% (d7087e0d) by +0.02%.

    Filename Base (37dd2b1) Head (d7087e0d) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    ChildChangeAccumulator.java 83.87% 96.77% +12.90%
    DoubleNode.java 100.00% 88.89% -11.11%
    ViewProcessor.java 92.35% 92.05% -0.31%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (d7087e0d) is created by Prow via merging commits: 37dd2b1 0c1ca6f.

@vkryachko
Copy link
Member Author

/retest

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 0c1ca6f link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit 3f4b32d into master Jul 20, 2020
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
@vkryachko vkryachko deleted the vk.kotlindoc_improvements branch October 20, 2020 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants