Skip to content

Revert caching fid & disk read on caller thread. #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2020
Merged

Revert caching fid & disk read on caller thread. #1767

merged 2 commits into from
Jul 8, 2020

Conversation

ankitaj224
Copy link
Contributor

Revert "Completing getId call with the disk reads on the caller thread."

This reverts commit f0ff299

@ankitaj224 ankitaj224 requested a review from fredquintana July 8, 2020 21:34
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (04a9e0c) Head (122761f1) Diff
    aar 58.2 kB 59.1 kB +947 B (+1.6%)
    apk (debug) 800 kB 801 kB +209 B (+0.0%)
    apk (release) 648 kB 648 kB +104 B (+0.0%)

Test Logs

Notes

Head commit (122761f1) is created by Prow via merging commits: 04a9e0c e4e8571.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-installations

    SDK overall coverage changed from 57.01% (04a9e0c) to 57.30% (122761f1) by +0.29%.

    Filename Base (04a9e0c) Head (122761f1) Diff
    FirebaseInstallations.java 97.81% 97.85% +0.04%
    GetIdListener.java ? 70.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (122761f1) is created by Prow via merging commits: 04a9e0c e4e8571.

@googlebot googlebot added the cla: yes Override cla label Jul 8, 2020
@ankitaj224 ankitaj224 merged commit 0ce007a into master Jul 8, 2020
@ankitaj224 ankitaj224 deleted the revertCachingRead branch July 8, 2020 21:55
@ankitaj224 ankitaj224 mentioned this pull request Jul 9, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fredquintana fredquintana fredquintana approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankitaj224 @google-oss-bot @fredquintana @googlebot