Skip to content

Klint test fixes. #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Klint test fixes. #1752

merged 1 commit into from
Jul 2, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 2, 2020

Because I miss the tests

@googlebot googlebot added the cla: yes Override cla label Jul 2, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database-ktx

    SDK overall coverage changed from ? (85ee822) to 75.00% (e233991c) by ?.

    Filename Base (85ee822) Head (e233991c) Diff
    Database.kt ? 75.00% ?
  • firebase-dynamic-links-ktx

    SDK overall coverage changed from ? (85ee822) to 77.78% (e233991c) by ?.

    Filename Base (85ee822) Head (e233991c) Diff
    FirebaseDynamicLinks.kt ? 77.78% ?
  • firebase-functions-ktx

    SDK overall coverage changed from ? (85ee822) to 100.00% (e233991c) by ?.

    Filename Base (85ee822) Head (e233991c) Diff
    Functions.kt ? 100.00% ?
  • firebase-inappmessaging-display-ktx

    SDK overall coverage changed from ? (85ee822) to 100.00% (e233991c) by ?.

    Filename Base (85ee822) Head (e233991c) Diff
    InAppMessagingDisplay.kt ? 100.00% ?
  • firebase-inappmessaging-ktx

    SDK overall coverage changed from ? (85ee822) to 100.00% (e233991c) by ?.

    Filename Base (85ee822) Head (e233991c) Diff
    InAppMessaging.kt ? 100.00% ?
  • firebase-storage-ktx

    SDK overall coverage changed from ? (85ee822) to 100.00% (e233991c) by ?.

    Filename Base (85ee822) Head (e233991c) Diff
    Storage.kt ? 100.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e233991c) is created by Prow via merging commits: 85ee822 0f30d91.

@google-oss-bot
Copy link
Contributor

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 0f30d91 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 80.7 kB 80.7 kB +2 B (+0.0%)
  • firebase-common

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 56.0 kB 56.0 kB +2 B (+0.0%)
    apk (debug) 687 kB 687 kB -1 B (-0.0%)
  • firebase-common-ktx

    Type Base (85ee822) Head (e233991c) Diff
    apk (debug) 1.41 MB 1.41 MB +1 B (+0.0%)
  • firebase-components

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 5.95 kB 5.94 kB -1 B (-0.0%)
    apk (debug) 29.6 kB 29.6 kB -1 B (-0.0%)
  • firebase-database

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 206 kB 206 kB +2 B (+0.0%)
    apk (debug) 1.08 MB 1.08 MB +1 B (+0.0%)
  • firebase-database-collection

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 195 kB 195 kB -2 B (-0.0%)
    apk (debug) 876 kB 876 kB +1 B (+0.0%)
  • firebase-database-ktx

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 394 kB 394 kB -1 B (-0.0%)
  • firebase-datatransport

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 90.3 kB 90.3 kB -1 B (-0.0%)
  • firebase-dynamic-links

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 208 kB 208 kB +3 B (+0.0%)
  • firebase-dynamic-links-ktx

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 396 kB 396 kB +3 B (+0.0%)
    apk (debug) 1.63 MB 1.63 MB +1 B (+0.0%)
  • firebase-encoders-json

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 5.95 kB 5.94 kB -1 B (-0.0%)
    apk (debug) 22.9 kB 22.8 kB -2 B (-0.0%)
  • firebase-functions

    Type Base (85ee822) Head (e233991c) Diff
    apk (debug) 1.16 MB 1.16 MB +1 B (+0.0%)
  • firebase-functions-ktx

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 463 kB 463 kB +1 B (+0.0%)
    apk (debug) 1.88 MB 1.88 MB -2 B (-0.0%)
  • firebase-inappmessaging

    Type Base (85ee822) Head (e233991c) Diff
    apk (debug) 3.68 MB 3.68 MB +1 B (+0.0%)
  • firebase-inappmessaging-ktx

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 815 kB 815 kB +1 B (+0.0%)
    apk (debug) 4.41 MB 4.41 MB +1 B (+0.0%)
  • firebase-installations

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 57.7 kB 57.7 kB -1 B (-0.0%)
    apk (debug) 709 kB 709 kB -1 B (-0.0%)
  • firebase-installations-interop

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 35.0 kB 35.0 kB +1 B (+0.0%)
    apk (debug) 662 kB 662 kB -2 B (-0.0%)
  • firebase-storage

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 206 kB 206 kB -1 B (-0.0%)
    apk (debug) 935 kB 935 kB -1 B (-0.0%)
  • firebase-storage-ktx

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 394 kB 394 kB -1 B (-0.0%)
    apk (debug) 1.66 MB 1.66 MB +3 B (+0.0%)
  • protolite-well-known-types

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 136 kB 136 kB -2 B (-0.0%)
  • transport-api

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 5.95 kB 5.94 kB -1 B (-0.0%)
    apk (debug) 17.6 kB 17.6 kB -1 B (-0.0%)
  • transport-backend-cct

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 43.0 kB 43.0 kB +1 B (+0.0%)
    apk (debug) 89.9 kB 89.9 kB +2 B (+0.0%)
  • transport-runtime

    Type Base (85ee822) Head (e233991c) Diff
    apk (aggressive) 30.6 kB 30.6 kB -2 B (-0.0%)
    apk (debug) 70.4 kB 70.4 kB -1 B (-0.0%)

Test Logs

Notes

Head commit (e233991c) is created by Prow via merging commits: 85ee822 0f30d91.

@rlazo rlazo requested review from vkryachko and VinayGuthal July 2, 2020 17:53
@rlazo rlazo merged commit 2844f80 into master Jul 2, 2020
@rlazo rlazo deleted the rl.ktlin29 branch July 2, 2020 19:29
@firebase firebase locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants