Add runtime support for Set-components #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
/retest |
VinayGuthal
approved these changes
Jan 3, 2019
ashwinraghav
reviewed
Jan 4, 2019
firebase-common/src/main/java/com/google/firebase/components/ComponentRuntime.java
Show resolved
Hide resolved
firebase-common/src/main/java/com/google/firebase/components/ComponentRuntime.java
Show resolved
Hide resolved
firebase-common/src/main/java/com/google/firebase/components/ComponentRuntime.java
Show resolved
Hide resolved
firebase-common/src/main/java/com/google/firebase/components/ComponentRuntime.java
Show resolved
Hide resolved
firebase-common/src/main/java/com/google/firebase/components/ComponentRuntime.java
Outdated
Show resolved
Hide resolved
ashwinraghav
approved these changes
Jan 10, 2019
| } | ||
| return delegateContainer.getProvider(anInterface); | ||
| } | ||
|
|
||
| @Override |
|
/retest |
|
@vkryachko: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gist of the change is that it introduces support for Set-multibindings that enables components to declare a dependency on a Set as well as to create components that contribute values to a Set.