Skip to content

Revert "Un-hide EmulatorSettings API" #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

samtstern
Copy link
Contributor

Reverts #1712

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2020

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (3c9f431) Head (f267712c) Diff
    aar 38.1 kB 38.1 kB -47 B (-0.1%)
    apk (aggressive) 56.0 kB 56.0 kB -8 B (-0.0%)
    apk (debug) 687 kB 687 kB -21 B (-0.0%)
    apk (release) 614 kB 614 kB +38 B (+0.0%)
  • firebase-components

    Type Base (3c9f431) Head (f267712c) Diff
    apk (aggressive) 5.95 kB 5.94 kB -4 B (-0.1%)
    apk (debug) 29.6 kB 29.6 kB -3 B (-0.0%)
  • firebase-database

    Type Base (3c9f431) Head (f267712c) Diff
    aar 482 kB 482 kB +7 B (+0.0%)
    apk (aggressive) 206 kB 206 kB -7 B (-0.0%)
    apk (debug) 1.08 MB 1.08 MB -99 B (-0.0%)
    apk (release) 976 kB 976 kB +14 B (+0.0%)
  • firebase-database-collection

    Type Base (3c9f431) Head (f267712c) Diff
    apk (aggressive) 195 kB 195 kB -1 B (-0.0%)
    apk (debug) 876 kB 876 kB -2 B (-0.0%)
  • firebase-firestore

    Type Base (3c9f431) Head (f267712c) Diff
    aar 996 kB 996 kB -6 B (-0.0%)
    apk (aggressive) 343 kB 343 kB +2 B (+0.0%)
    apk (debug) 3.36 MB 3.36 MB -33 B (-0.0%)
    apk (release) 3.04 MB 3.04 MB -2 B (-0.0%)
  • firebase-functions

    Type Base (3c9f431) Head (f267712c) Diff
    aar 26.4 kB 26.4 kB -30 B (-0.1%)
    apk (aggressive) 275 kB 275 kB -2 B (-0.0%)
    apk (debug) 1.16 MB 1.16 MB -44 B (-0.0%)
    apk (release) 1.05 MB 1.05 MB -68 B (-0.0%)
  • protolite-well-known-types

    Type Base (3c9f431) Head (f267712c) Diff
    apk (debug) 703 kB 703 kB -3 B (-0.0%)

Test Logs

Notes

Head commit (f267712c) is created by Prow via merging commits: 3c9f431 1d6d2eb.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2020

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 49.95% (3c9f431) to 49.99% (f267712c) by +0.03%.

    Filename Base (3c9f431) Head (f267712c) Diff
    ChildChangeAccumulator.java 83.87% 96.77% +12.90%
    DoubleNode.java 100.00% 88.89% -11.11%
    ViewProcessor.java 92.05% 92.35% +0.31%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (f267712c) is created by Prow via merging commits: 3c9f431 1d6d2eb.

@samtstern
Copy link
Contributor Author

/retest

@google-oss-bot
Copy link
Contributor

@samtstern: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 1d6d2eb link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@samtstern samtstern added the cla: yes Override cla label Jun 30, 2020
@samtstern samtstern merged commit db66120 into master Jun 30, 2020
@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
@kaibolay kaibolay deleted the revert-1712-ss-unhide-emulator-settings branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants