Bump gradle-errorprone-plugin from 0.7.1 to 1.2.1 #1732

dependabot · 2020-06-29T06:13:14Z

Bumps gradle-errorprone-plugin from 0.7.1 to 1.2.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

google-oss-bot · 2020-06-29T06:13:28Z

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rlazo · 2020-06-29T15:26:52Z

/ok-to-test

google-oss-bot · 2020-06-29T15:41:20Z

Coverage Report

Affected SDKs

firebase-database

SDK overall coverage changed from 49.97% (15be821) to 49.94% (c56554af) by -0.02%.

Filename Base (15be821) Head (c56554af) Diff

DoubleNode.java 100.00% 88.89% -11.11%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (c56554af) is created by Prow via merging commits: 15be821 cb3f342.

google-oss-bot · 2020-06-29T15:43:02Z

Binary Size Report

Affected SDKs

firebase-abt

Type Base (15be821) Head (c56554af) Diff

aar ? 33.0 kB ? (?)

apk (aggressive) ? 80.7 kB ? (?)

apk (debug) ? 985 kB ? (?)

apk (release) ? 880 kB ? (?)
firebase-common

Type Base (15be821) Head (c56554af) Diff

aar ? 38.1 kB ? (?)

apk (aggressive) ? 56.0 kB ? (?)

apk (debug) ? 687 kB ? (?)

apk (release) ? 614 kB ? (?)
firebase-common-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 5.98 kB ? (?)

apk (aggressive) ? 244 kB ? (?)

apk (debug) ? 1.41 MB ? (?)

apk (release) ? 1.25 MB ? (?)
firebase-components

Type Base (15be821) Head (c56554af) Diff

aar ? 34.5 kB ? (?)

apk (aggressive) ? 5.95 kB ? (?)

apk (debug) ? 29.6 kB ? (?)

apk (release) ? 24.6 kB ? (?)
firebase-config

Type Base (15be821) Head (c56554af) Diff

aar ? 193 kB ? (?)

apk (aggressive) ? 179 kB ? (?)

apk (debug) ? 1.12 MB ? (?)

apk (release) ? 1.00 MB ? (?)
firebase-config-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 5.84 kB ? (?)

apk (aggressive) ? 367 kB ? (?)

apk (debug) ? 1.84 MB ? (?)

apk (release) ? 1.64 MB ? (?)
firebase-crashlytics

Type Base (15be821) Head (c56554af) Diff

aar ? 410 kB ? (?)

apk (aggressive) ? 481 kB ? (?)

apk (debug) ? 1.37 MB ? (?)

apk (release) ? 1.25 MB ? (?)
firebase-crashlytics-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 7.16 kB ? (?)

apk (aggressive) ? 669 kB ? (?)

apk (debug) ? 2.09 MB ? (?)

apk (release) ? 1.88 MB ? (?)
firebase-crashlytics-ndk

Type Base (15be821) Head (c56554af) Diff

aar ? 599 kB ? (?)

apk (aggressive) ? 1.07 MB ? (?)

apk (debug) ? 1.96 MB ? (?)

apk (release) ? 1.83 MB ? (?)
firebase-database

Type Base (15be821) Head (c56554af) Diff

aar ? 482 kB ? (?)

apk (aggressive) ? 206 kB ? (?)

apk (debug) ? 1.08 MB ? (?)

apk (release) ? 976 kB ? (?)
firebase-database-collection

Type Base (15be821) Head (c56554af) Diff

aar ? 34.2 kB ? (?)

apk (aggressive) ? 195 kB ? (?)

apk (debug) ? 876 kB ? (?)

apk (release) ? 796 kB ? (?)
firebase-database-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 7.43 kB ? (?)

apk (aggressive) ? 394 kB ? (?)

apk (debug) ? 1.80 MB ? (?)

apk (release) ? 1.61 MB ? (?)
firebase-datatransport

Type Base (15be821) Head (c56554af) Diff

aar ? 5.04 kB ? (?)

apk (aggressive) ? 90.3 kB ? (?)

apk (debug) ? 757 kB ? (?)

apk (release) ? 677 kB ? (?)
firebase-decoders-json

Type Base (15be821) Head (c56554af) Diff

aar ? 7.52 kB ? (?)

apk (aggressive) ? 5.95 kB ? (?)

apk (debug) ? 18.2 kB ? (?)

apk (release) ? 14.7 kB ? (?)
firebase-dynamic-links

Type Base (15be821) Head (c56554af) Diff

aar ? 51.2 kB ? (?)

apk (aggressive) ? 208 kB ? (?)

apk (debug) ? 905 kB ? (?)

apk (release) ? 825 kB ? (?)
firebase-dynamic-links-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 8.01 kB ? (?)

apk (aggressive) ? 396 kB ? (?)

apk (debug) ? 1.63 MB ? (?)

apk (release) ? 1.46 MB ? (?)
firebase-encoders-json

Type Base (15be821) Head (c56554af) Diff

aar ? 18.2 kB ? (?)

apk (aggressive) ? 5.95 kB ? (?)

apk (debug) ? 22.9 kB ? (?)

apk (release) ? 19.1 kB ? (?)
firebase-encoders-reflective

Type Base (15be821) Head (c56554af) Diff

aar ? 7.65 kB ? (?)

apk (aggressive) ? 5.95 kB ? (?)

apk (debug) ? 25.2 kB ? (?)

apk (release) ? 21.2 kB ? (?)
firebase-firestore

Type Base (15be821) Head (c56554af) Diff

aar ? 996 kB ? (?)

apk (aggressive) ? 343 kB ? (?)

apk (debug) ? 3.36 MB ? (?)

apk (release) ? 3.04 MB ? (?)
firebase-firestore-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 7.19 kB ? (?)

apk (aggressive) ? 530 kB ? (?)

apk (debug) ? 4.09 MB ? (?)

apk (release) ? 3.68 MB ? (?)
firebase-functions

Type Base (15be821) Head (c56554af) Diff

aar ? 26.4 kB ? (?)

apk (aggressive) ? 275 kB ? (?)

apk (debug) ? 1.16 MB ? (?)

apk (release) ? 1.05 MB ? (?)
firebase-functions-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 5.84 kB ? (?)

apk (aggressive) ? 463 kB ? (?)

apk (debug) ? 1.88 MB ? (?)

apk (release) ? 1.69 MB ? (?)
firebase-inappmessaging

Type Base (15be821) Head (c56554af) Diff

aar ? 440 kB ? (?)

apk (aggressive) ? 628 kB ? (?)

apk (debug) ? 3.68 MB ? (?)

apk (release) ? 3.29 MB ? (?)
firebase-inappmessaging-display

Type Base (15be821) Head (c56554af) Diff

aar ? 167 kB ? (?)
firebase-inappmessaging-display-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 22.2 kB ? (?)
firebase-inappmessaging-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 5.28 kB ? (?)

apk (aggressive) ? 815 kB ? (?)

apk (debug) ? 4.41 MB ? (?)

apk (release) ? 3.93 MB ? (?)
firebase-installations

Type Base (15be821) Head (c56554af) Diff

aar ? 58.2 kB ? (?)

apk (aggressive) ? 57.7 kB ? (?)

apk (debug) ? 709 kB ? (?)

apk (release) ? 634 kB ? (?)
firebase-installations-interop

Type Base (15be821) Head (c56554af) Diff

aar ? 7.51 kB ? (?)

apk (aggressive) ? 35.0 kB ? (?)

apk (debug) ? 662 kB ? (?)

apk (release) ? 593 kB ? (?)
firebase-segmentation

Type Base (15be821) Head (c56554af) Diff

aar ? 34.8 kB ? (?)

apk (aggressive) ? 605 kB ? (?)

apk (debug) ? 1.33 MB ? (?)

apk (release) ? 1.18 MB ? (?)
firebase-storage

Type Base (15be821) Head (c56554af) Diff

aar ? 119 kB ? (?)

apk (aggressive) ? 206 kB ? (?)

apk (debug) ? 935 kB ? (?)

apk (release) ? 850 kB ? (?)
firebase-storage-ktx

Type Base (15be821) Head (c56554af) Diff

aar ? 6.14 kB ? (?)

apk (aggressive) ? 394 kB ? (?)

apk (debug) ? 1.66 MB ? (?)

apk (release) ? 1.49 MB ? (?)
protolite-well-known-types

Type Base (15be821) Head (c56554af) Diff

aar ? 998 kB ? (?)

apk (aggressive) ? 136 kB ? (?)

apk (debug) ? 703 kB ? (?)

apk (release) ? 659 kB ? (?)
transport-api

Type Base (15be821) Head (c56554af) Diff

aar ? 6.59 kB ? (?)

apk (aggressive) ? 5.95 kB ? (?)

apk (debug) ? 17.6 kB ? (?)

apk (release) ? 14.3 kB ? (?)
transport-backend-cct

Type Base (15be821) Head (c56554af) Diff

aar ? 39.0 kB ? (?)

apk (aggressive) ? 43.0 kB ? (?)

apk (debug) ? 89.9 kB ? (?)

apk (release) ? 81.6 kB ? (?)
transport-runtime

Type Base (15be821) Head (c56554af) Diff

aar ? 127 kB ? (?)

apk (aggressive) ? 30.6 kB ? (?)

apk (debug) ? 70.4 kB ? (?)

apk (release) ? 62.2 kB ? (?)

Test Logs

Head (c56554af): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1732/binary-size/1278785572940288005

Notes

Head commit (c56554af) is created by Prow via merging commits: 15be821 cb3f342.

rlazo · 2020-06-29T16:22:34Z

/test check-changed

vkryachko · 2020-06-29T17:31:19Z

Not sure what the effect of this would be, one thing that stands out is that we are not actually updating the version of errorprone itself, only the gradle plugin.

firebase-android-sdk/gradle/errorProne.gradle

Line 17 in ce9baa7

def errorproneVersion = '2.3.2'

rlazo · 2020-06-30T14:49:50Z

@dependabot rebase

rlazo · 2020-07-02T14:26:30Z

@dependabot rebase

rlazo · 2020-07-02T16:20:35Z

@dependabot rebase

rlazo · 2020-07-02T19:30:23Z

@dependabot rebase

rlazo · 2020-07-02T20:19:14Z

@dependabot rebase

Bumps gradle-errorprone-plugin from 0.7.1 to 1.2.1. Signed-off-by: dependabot[bot] <[email protected]>

rlazo · 2020-07-03T13:29:14Z

Not sure what the effect of this would be, one thing that stands out is that we are not actually updating the version of errorprone itself, only the gradle plugin.

firebase-android-sdk/gradle/errorProne.gradle

Line 17 in ce9baa7

def errorproneVersion = '2.3.2'

I'll update the errorprone version in a follow up PR

dependabot bot added the External Dependency label Jun 29, 2020

googlebot added the cla: yes Override cla label Jun 29, 2020

google-oss-bot added needs-ok-to-test size/XS labels Jun 29, 2020

google-oss-bot added ok-to-test and removed needs-ok-to-test labels Jun 29, 2020

dependabot bot force-pushed the dependabot/gradle/net.ltgt.gradle-gradle-errorprone-plugin-1.2.1 branch from 58545b7 to c4f94f7 Compare June 29, 2020 15:43

ashwinraghav requested a review from vkryachko June 29, 2020 16:57

dependabot bot force-pushed the dependabot/gradle/net.ltgt.gradle-gradle-errorprone-plugin-1.2.1 branch from c4f94f7 to fca5032 Compare June 30, 2020 14:50

dependabot bot force-pushed the dependabot/gradle/net.ltgt.gradle-gradle-errorprone-plugin-1.2.1 branch from fca5032 to da5338a Compare July 2, 2020 14:26

dependabot bot force-pushed the dependabot/gradle/net.ltgt.gradle-gradle-errorprone-plugin-1.2.1 branch from da5338a to f37585a Compare July 2, 2020 16:20

dependabot bot force-pushed the dependabot/gradle/net.ltgt.gradle-gradle-errorprone-plugin-1.2.1 branch from f37585a to 6756d57 Compare July 2, 2020 19:30

Bump gradle-errorprone-plugin from 0.7.1 to 1.2.1

cb3f342

Bumps gradle-errorprone-plugin from 0.7.1 to 1.2.1. Signed-off-by: dependabot[bot] <[email protected]>

dependabot bot force-pushed the dependabot/gradle/net.ltgt.gradle-gradle-errorprone-plugin-1.2.1 branch from 6756d57 to cb3f342 Compare July 2, 2020 20:19

rlazo self-requested a review July 3, 2020 13:29

rlazo approved these changes Jul 3, 2020

View reviewed changes

rlazo merged commit bc666db into master Jul 3, 2020

rlazo deleted the dependabot/gradle/net.ltgt.gradle-gradle-errorprone-plugin-1.2.1 branch July 3, 2020 13:29

firebase locked and limited conversation to collaborators Aug 3, 2020

Bump gradle-errorprone-plugin from 0.7.1 to 1.2.1 #1732

Bump gradle-errorprone-plugin from 0.7.1 to 1.2.1 #1732

Uh oh!

Conversation

dependabot bot commented on behalf of github Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-bot commented Jun 29, 2020

Uh oh!

rlazo commented Jun 29, 2020

Uh oh!

google-oss-bot commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Affected SDKs

firebase-database

Test Logs

Notes

Uh oh!

google-oss-bot commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

firebase-abt

firebase-common

firebase-common-ktx

firebase-components

firebase-config

firebase-config-ktx

firebase-crashlytics

firebase-crashlytics-ktx

firebase-crashlytics-ndk

firebase-database

firebase-database-collection

firebase-database-ktx

firebase-datatransport

firebase-decoders-json

firebase-dynamic-links

firebase-dynamic-links-ktx

firebase-encoders-json

firebase-encoders-reflective

firebase-firestore

firebase-firestore-ktx

firebase-functions

firebase-functions-ktx

firebase-inappmessaging

firebase-inappmessaging-display

firebase-inappmessaging-display-ktx

firebase-inappmessaging-ktx

firebase-installations

firebase-installations-interop

firebase-segmentation

firebase-storage

firebase-storage-ktx

protolite-well-known-types

transport-api

transport-backend-cct

transport-runtime

Test Logs

Notes

Uh oh!

rlazo commented Jun 29, 2020

Uh oh!

vkryachko commented Jun 29, 2020

Uh oh!

rlazo commented Jun 30, 2020

Uh oh!

rlazo commented Jul 2, 2020

Uh oh!

rlazo commented Jul 2, 2020

Uh oh!

rlazo commented Jul 2, 2020

Uh oh!

rlazo commented Jul 2, 2020

Uh oh!

rlazo commented Jul 3, 2020

Uh oh!

Uh oh!

dependabot bot commented on behalf of github Jun 29, 2020 •

edited

Loading

google-oss-bot commented Jun 29, 2020 •

edited

Loading

`firebase-database`

google-oss-bot commented Jun 29, 2020 •

edited

Loading

`firebase-abt`

`firebase-common`

`firebase-common-ktx`

`firebase-components`

`firebase-config`

`firebase-config-ktx`

`firebase-crashlytics`

`firebase-crashlytics-ktx`

`firebase-crashlytics-ndk`

`firebase-database`

`firebase-database-collection`

`firebase-database-ktx`

`firebase-datatransport`

`firebase-decoders-json`

`firebase-dynamic-links`

`firebase-dynamic-links-ktx`

`firebase-encoders-json`

`firebase-encoders-reflective`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-functions`

`firebase-functions-ktx`

`firebase-inappmessaging`

`firebase-inappmessaging-display`

`firebase-inappmessaging-display-ktx`

`firebase-inappmessaging-ktx`

`firebase-installations`

`firebase-installations-interop`

`firebase-segmentation`

`firebase-storage`

`firebase-storage-ktx`

`protolite-well-known-types`

`transport-api`

`transport-backend-cct`

`transport-runtime`