Skip to content

Fixing NPE and correcting corresponding annotations. #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Conversation

ankitaj224
Copy link
Contributor

Reported by Google Duo dog-fooding : b/158637349

Reported by Google Duo dog-fooding : b/158637349
@ankitaj224 ankitaj224 requested a review from andirayo June 24, 2020 20:02
@googlebot googlebot added the cla: yes Override cla label Jun 24, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 24, 2020

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (5ea6635) Head (6397fc5a) Diff
    aar ? 38.1 kB ? (?)
    apk (aggressive) ? 82.7 kB ? (?)
    apk (debug) ? 772 kB ? (?)
    apk (release) ? 637 kB ? (?)
  • firebase-components

    Type Base (5ea6635) Head (6397fc5a) Diff
    aar ? 34.5 kB ? (?)
    apk (aggressive) ? 11.0 kB ? (?)
    apk (debug) ? 35.8 kB ? (?)
    apk (release) ? 25.4 kB ? (?)
  • firebase-installations

    Type Base (5ea6635) Head (6397fc5a) Diff
    aar ? 58.2 kB ? (?)
    apk (aggressive) ? 84.4 kB ? (?)
    apk (debug) ? 796 kB ? (?)
    apk (release) ? 657 kB ? (?)
  • firebase-installations-interop

    Type Base (5ea6635) Head (6397fc5a) Diff
    aar ? 7.51 kB ? (?)
    apk (aggressive) ? 61.7 kB ? (?)
    apk (debug) ? 744 kB ? (?)
    apk (release) ? 616 kB ? (?)

Test Logs

Notes

Head commit (6397fc5a) is created by Prow via merging commits: 5ea6635 738043c.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 24, 2020

Coverage Report

Affected SDKs

  • firebase-installations

    SDK overall coverage changed from ? (5ea6635) to 57.01% (6397fc5a) by ?.

    Click to show coverage changes in 18 files.
    Filename Base (5ea6635) Head (6397fc5a) Diff
    AutoValue_InstallationResponse.java ? 42.86% ?
    AutoValue_PersistedInstallationEntry.java ? 61.18% ?
    AutoValue_TokenResult.java ? 45.65% ?
    AwaitListener.java ? 0.00% ?
    CrossProcessLock.java ? 51.85% ?
    FirebaseInstallationServiceClient.java ? 5.12% ?
    FirebaseInstallations.java ? 97.81% ?
    FirebaseInstallationsException.java ? 76.92% ?
    FirebaseInstallationsRegistrar.java ? 100.00% ?
    GetAuthTokenListener.java ? 90.00% ?
    IidStore.java ? 44.78% ?
    InstallationResponse.java ? 100.00% ?
    PersistedInstallation.java ? 96.77% ?
    PersistedInstallationEntry.java ? 100.00% ?
    RandomFidGenerator.java ? 20.00% ?
    StateListener.java ? 0.00% ?
    TokenResult.java ? 100.00% ?
    Utils.java ? 100.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (6397fc5a) is created by Prow via merging commits: 5ea6635 738043c.

@ankitaj224 ankitaj224 merged commit 93cdb04 into master Jun 25, 2020
@ankitaj224 ankitaj224 deleted the nullFixFis branch June 25, 2020 02:32
@firebase firebase locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants