-
Notifications
You must be signed in to change notification settings - Fork 615
Unified emulator settings for Firestore #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c621f5b
Unified emulator settings for Firestore
samtstern b307898
Merge branch 'master' into ss-firestore-emulator-settings
samtstern 1a151bb
Hide new constants
samtstern f9ff9d6
Merge remote-tracking branch 'origin/master' into ss-firestore-emulat…
samtstern 85b6170
Respond to Sebastian's review comments
samtstern a79f753
Merge remote-tracking branch 'origin/master' into ss-firestore-emulat…
samtstern 9d499c1
Add one more test
samtstern d90d91f
Merge remote-tracking branch 'origin/master' into ss-firestore-emulat…
samtstern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 97 additions & 0 deletions
97
firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
// Copyright 2020 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.firestore; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertFalse; | ||
|
||
import androidx.annotation.NonNull; | ||
import androidx.test.platform.app.InstrumentationRegistry; | ||
import com.google.firebase.FirebaseApp; | ||
import com.google.firebase.FirebaseOptions; | ||
import com.google.firebase.emulators.EmulatedServiceSettings; | ||
import com.google.firebase.emulators.EmulatorSettings; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.robolectric.RobolectricTestRunner; | ||
import org.robolectric.annotation.Config; | ||
|
||
@RunWith(RobolectricTestRunner.class) | ||
@Config(manifest = Config.NONE) | ||
public class FirebaseFirestoreTest { | ||
|
||
@Test | ||
public void getInstance_withEmulator() { | ||
FirebaseApp app = getApp("getInstance_withEmulator"); | ||
|
||
app.enableEmulators( | ||
new EmulatorSettings.Builder() | ||
.addEmulatedService( | ||
FirebaseFirestore.EMULATOR, new EmulatedServiceSettings("10.0.2.2", 8080)) | ||
.build()); | ||
|
||
FirebaseFirestore firestore = FirebaseFirestore.getInstance(app); | ||
FirebaseFirestoreSettings settings = firestore.getFirestoreSettings(); | ||
|
||
assertEquals(settings.getHost(), "10.0.2.2:8080"); | ||
assertFalse(settings.isSslEnabled()); | ||
} | ||
|
||
@Test | ||
public void getInstance_withEmulator_mergeSettingsSuccess() { | ||
FirebaseApp app = getApp("getInstance_withEmulator_mergeSettingsSuccess"); | ||
app.enableEmulators( | ||
new EmulatorSettings.Builder() | ||
.addEmulatedService( | ||
FirebaseFirestore.EMULATOR, new EmulatedServiceSettings("10.0.2.2", 8080)) | ||
.build()); | ||
|
||
FirebaseFirestore firestore = FirebaseFirestore.getInstance(app); | ||
firestore.setFirestoreSettings( | ||
new FirebaseFirestoreSettings.Builder().setPersistenceEnabled(false).build()); | ||
|
||
FirebaseFirestoreSettings settings = firestore.getFirestoreSettings(); | ||
|
||
assertEquals(settings.getHost(), "10.0.2.2:8080"); | ||
assertFalse(settings.isSslEnabled()); | ||
assertFalse(settings.isPersistenceEnabled()); | ||
} | ||
|
||
@Test(expected = IllegalStateException.class) | ||
samtstern marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public void getInstance_withEmulator_mergeSettingsFailure() { | ||
FirebaseApp app = getApp("getInstance_withEmulator_mergeSettingsFailure"); | ||
app.enableEmulators( | ||
new EmulatorSettings.Builder() | ||
.addEmulatedService( | ||
FirebaseFirestore.EMULATOR, new EmulatedServiceSettings("10.0.2.2", 8080)) | ||
.build()); | ||
|
||
FirebaseFirestore firestore = FirebaseFirestore.getInstance(app); | ||
firestore.setFirestoreSettings( | ||
new FirebaseFirestoreSettings.Builder().setHost("myhost.com").build()); | ||
} | ||
samtstern marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@NonNull | ||
private FirebaseApp getApp(@NonNull String name) { | ||
return FirebaseApp.initializeApp( | ||
InstrumentationRegistry.getInstrumentation().getContext(), | ||
new FirebaseOptions.Builder() | ||
.setApplicationId("appid") | ||
.setApiKey("apikey") | ||
.setProjectId("projectid") | ||
.build(), | ||
name); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.