Skip to content

Use the javaversion constant instead of string. #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Use the javaversion constant instead of string. #1673

merged 1 commit into from
Jun 18, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 17, 2020

@rlazo rlazo requested review from vkryachko and ashwinraghav June 17, 2020 16:09
@googlebot googlebot added the cla: yes Override cla label Jun 17, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • transport-api

    Type Base (43f5c6d) Head (3272c15d) Diff
    apk (aggressive) 11.0 kB 11.0 kB +6 B (+0.1%)
    apk (debug) 23.0 kB 23.0 kB +15 B (+0.1%)
  • transport-runtime

    Type Base (43f5c6d) Head (3272c15d) Diff
    apk (aggressive) 35.6 kB 35.6 kB -17 B (-0.0%)
    apk (debug) 80.6 kB 80.6 kB -24 B (-0.0%)

Test Logs

Notes

Head commit (3272c15d) is created by Prow via merging commits: 43f5c6d 30d1bc5.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (43f5c6d) and head commit (3272c15d).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (3272c15d) is created by Prow via merging commits: 43f5c6d 30d1bc5.

@rlazo rlazo merged commit f6b788e into master Jun 18, 2020
@rlazo rlazo deleted the rl.verconst branch June 18, 2020 14:08
@firebase firebase locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants