Skip to content

Add ability to publish JAR SDKs #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2020
Merged

Add ability to publish JAR SDKs #1602

merged 5 commits into from
Jul 3, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Override cla label May 28, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 28, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-storage

    SDK overall coverage changed from 85.44% (15be821) to 85.48% (e452c427) by +0.04%.

    Filename Base (15be821) Head (e452c427) Diff
    StreamDownloadTask.java 88.41% 88.89% +0.48%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e452c427) is created by Prow via merging commits: 15be821 666ed16.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 28, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (15be821) Head (e452c427) Diff
    aar ? 33.0 kB ? (?)
    apk (aggressive) ? 80.7 kB ? (?)
    apk (debug) ? 985 kB ? (?)
    apk (release) ? 880 kB ? (?)

  • firebase-common

    Type Base (15be821) Head (e452c427) Diff
    aar ? 38.1 kB ? (?)
    apk (aggressive) ? 56.0 kB ? (?)
    apk (debug) ? 687 kB ? (?)
    apk (release) ? 614 kB ? (?)

  • firebase-common-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 5.98 kB ? (?)
    apk (aggressive) ? 243 kB ? (?)
    apk (debug) ? 1.41 MB ? (?)
    apk (release) ? 1.25 MB ? (?)

  • firebase-components

    Type Base (15be821) Head (e452c427) Diff
    aar ? 34.5 kB ? (?)
    apk (aggressive) ? 5.95 kB ? (?)
    apk (debug) ? 29.6 kB ? (?)
    apk (release) ? 24.6 kB ? (?)

  • firebase-config

    Type Base (15be821) Head (e452c427) Diff
    aar ? 193 kB ? (?)
    apk (aggressive) ? 179 kB ? (?)
    apk (debug) ? 1.12 MB ? (?)
    apk (release) ? 1.00 MB ? (?)

  • firebase-config-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 5.84 kB ? (?)
    apk (aggressive) ? 367 kB ? (?)
    apk (debug) ? 1.84 MB ? (?)
    apk (release) ? 1.64 MB ? (?)

  • firebase-crashlytics

    Type Base (15be821) Head (e452c427) Diff
    aar ? 410 kB ? (?)
    apk (aggressive) ? 481 kB ? (?)
    apk (debug) ? 1.37 MB ? (?)
    apk (release) ? 1.25 MB ? (?)

  • firebase-crashlytics-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 7.16 kB ? (?)
    apk (aggressive) ? 669 kB ? (?)
    apk (debug) ? 2.09 MB ? (?)
    apk (release) ? 1.88 MB ? (?)

  • firebase-crashlytics-ndk

    Type Base (15be821) Head (e452c427) Diff
    aar ? 599 kB ? (?)
    apk (aggressive) ? 1.07 MB ? (?)
    apk (debug) ? 1.96 MB ? (?)
    apk (release) ? 1.83 MB ? (?)

  • firebase-database

    Type Base (15be821) Head (e452c427) Diff
    aar ? 482 kB ? (?)
    apk (aggressive) ? 206 kB ? (?)
    apk (debug) ? 1.08 MB ? (?)
    apk (release) ? 976 kB ? (?)

  • firebase-database-collection

    Type Base (15be821) Head (e452c427) Diff
    aar ? 34.2 kB ? (?)
    apk (aggressive) ? 195 kB ? (?)
    apk (debug) ? 876 kB ? (?)
    apk (release) ? 796 kB ? (?)

  • firebase-database-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 7.43 kB ? (?)
    apk (aggressive) ? 394 kB ? (?)
    apk (debug) ? 1.80 MB ? (?)
    apk (release) ? 1.61 MB ? (?)

  • firebase-datatransport

    Type Base (15be821) Head (e452c427) Diff
    aar ? 5.04 kB ? (?)
    apk (aggressive) ? 90.3 kB ? (?)
    apk (debug) ? 757 kB ? (?)
    apk (release) ? 677 kB ? (?)

  • firebase-decoders-json

    Type Base (15be821) Head (e452c427) Diff
    aar ? 7.52 kB ? (?)
    apk (aggressive) ? 5.95 kB ? (?)
    apk (debug) ? 18.2 kB ? (?)
    apk (release) ? 14.7 kB ? (?)

  • firebase-dynamic-links

    Type Base (15be821) Head (e452c427) Diff
    aar ? 51.2 kB ? (?)
    apk (aggressive) ? 208 kB ? (?)
    apk (debug) ? 905 kB ? (?)
    apk (release) ? 825 kB ? (?)

  • firebase-dynamic-links-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 8.01 kB ? (?)
    apk (aggressive) ? 396 kB ? (?)
    apk (debug) ? 1.63 MB ? (?)
    apk (release) ? 1.46 MB ? (?)

  • firebase-encoders-json

    Type Base (15be821) Head (e452c427) Diff
    aar ? 18.2 kB ? (?)
    apk (aggressive) ? 5.95 kB ? (?)
    apk (debug) ? 22.9 kB ? (?)
    apk (release) ? 19.1 kB ? (?)

  • firebase-encoders-reflective

    Type Base (15be821) Head (e452c427) Diff
    aar ? 7.65 kB ? (?)
    apk (aggressive) ? 5.95 kB ? (?)
    apk (debug) ? 25.2 kB ? (?)
    apk (release) ? 21.2 kB ? (?)

  • firebase-firestore

    Type Base (15be821) Head (e452c427) Diff
    aar ? 996 kB ? (?)
    apk (aggressive) ? 343 kB ? (?)
    apk (debug) ? 3.36 MB ? (?)
    apk (release) ? 3.04 MB ? (?)

  • firebase-firestore-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 7.19 kB ? (?)
    apk (aggressive) ? 530 kB ? (?)
    apk (debug) ? 4.09 MB ? (?)
    apk (release) ? 3.68 MB ? (?)

  • firebase-functions

    Type Base (15be821) Head (e452c427) Diff
    aar ? 26.4 kB ? (?)
    apk (aggressive) ? 275 kB ? (?)
    apk (debug) ? 1.16 MB ? (?)
    apk (release) ? 1.05 MB ? (?)

  • firebase-functions-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 5.84 kB ? (?)
    apk (aggressive) ? 463 kB ? (?)
    apk (debug) ? 1.88 MB ? (?)
    apk (release) ? 1.69 MB ? (?)

  • firebase-inappmessaging

    Type Base (15be821) Head (e452c427) Diff
    aar ? 440 kB ? (?)
    apk (aggressive) ? 628 kB ? (?)
    apk (debug) ? 3.68 MB ? (?)
    apk (release) ? 3.29 MB ? (?)

  • firebase-inappmessaging-display

    Type Base (15be821) Head (e452c427) Diff
    aar ? 167 kB ? (?)

  • firebase-inappmessaging-display-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 22.2 kB ? (?)

  • firebase-inappmessaging-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 5.28 kB ? (?)
    apk (aggressive) ? 815 kB ? (?)
    apk (debug) ? 4.41 MB ? (?)
    apk (release) ? 3.93 MB ? (?)

  • firebase-installations

    Type Base (15be821) Head (e452c427) Diff
    aar ? 58.2 kB ? (?)
    apk (aggressive) ? 57.7 kB ? (?)
    apk (debug) ? 709 kB ? (?)
    apk (release) ? 634 kB ? (?)

  • firebase-installations-interop

    Type Base (15be821) Head (e452c427) Diff
    aar ? 7.51 kB ? (?)
    apk (aggressive) ? 35.0 kB ? (?)
    apk (debug) ? 662 kB ? (?)
    apk (release) ? 593 kB ? (?)

  • firebase-segmentation

    Type Base (15be821) Head (e452c427) Diff
    aar ? 34.8 kB ? (?)
    apk (aggressive) ? 605 kB ? (?)
    apk (debug) ? 1.33 MB ? (?)
    apk (release) ? 1.18 MB ? (?)

  • firebase-storage

    Type Base (15be821) Head (e452c427) Diff
    aar ? 119 kB ? (?)
    apk (aggressive) ? 206 kB ? (?)
    apk (debug) ? 935 kB ? (?)
    apk (release) ? 850 kB ? (?)

  • firebase-storage-ktx

    Type Base (15be821) Head (e452c427) Diff
    aar ? 6.14 kB ? (?)
    apk (aggressive) ? 394 kB ? (?)
    apk (debug) ? 1.66 MB ? (?)
    apk (release) ? 1.49 MB ? (?)

  • protolite-well-known-types

    Type Base (15be821) Head (e452c427) Diff
    aar ? 998 kB ? (?)
    apk (aggressive) ? 136 kB ? (?)
    apk (debug) ? 703 kB ? (?)
    apk (release) ? 659 kB ? (?)

  • transport-api

    Type Base (15be821) Head (e452c427) Diff
    aar ? 6.59 kB ? (?)
    apk (aggressive) ? 5.95 kB ? (?)
    apk (debug) ? 17.6 kB ? (?)
    apk (release) ? 14.3 kB ? (?)

  • transport-backend-cct

    Type Base (15be821) Head (e452c427) Diff
    aar ? 39.0 kB ? (?)
    apk (aggressive) ? 43.0 kB ? (?)
    apk (debug) ? 89.9 kB ? (?)
    apk (release) ? 81.6 kB ? (?)

  • transport-runtime

    Type Base (15be821) Head (e452c427) Diff
    aar ? 127 kB ? (?)
    apk (aggressive) ? 30.6 kB ? (?)
    apk (debug) ? 70.4 kB ? (?)
    apk (release) ? 62.2 kB ? (?)

Test Logs

Notes

Head commit (e452c427) is created by Prow via merging commits: 15be821 666ed16.

@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko marked this pull request as draft June 12, 2020 18:16
@vkryachko vkryachko changed the title WIP add java-library support. Add ability to publish JAR SDKs Jun 12, 2020
@vkryachko vkryachko force-pushed the vk.java_library_support branch from c353b12 to 3ccd1c5 Compare June 30, 2020 20:07
@vkryachko vkryachko marked this pull request as ready for review June 30, 2020 20:07
@vkryachko vkryachko requested a review from rlazo June 30, 2020 20:08
rlazo
rlazo reviewed Jul 2, 2020
View reviewed changes
@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko requested a review from rlazo July 2, 2020 15:32
@rlazo
Copy link
Collaborator

rlazo commented Jul 2, 2020

/retest

1 similar comment
@rlazo
Copy link
Collaborator

rlazo commented Jul 2, 2020

/retest

@vkryachko vkryachko merged commit d16fc4f into master Jul 3, 2020
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
@vkryachko vkryachko deleted the vk.java_library_support branch October 20, 2020 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @rlazo @googlebot