Cache FID to avoid multiple disk reads. #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (50268b61) is created by Prow via merging commits: b26d198 3c974c4. |
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (50268b61) is created by Prow via merging commits: b26d198 3c974c4. |
andirayo
reviewed
May 18, 2020
There was a problem hiding this comment.
I would recommend to do all the logic inside of #doGetId:
private String doGetId() {
// only read FID once from disk per session. Note: cachedFid will be reset if FID is deleted.
if (cachedFid != null) {
return cachedFid;
}
PersistedInstallationEntry prefs = getPrefsWithGeneratedIdMultiProcessSafe();
networkExecutor.execute(() -> doNetworkCall(false));
if (prefs.status == REGISTERED) { // pseudo-code
cachedFid = prefs.getFirebaseInstallationId();
}
return prefs.getFirebaseInstallationId();
}
...ase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java
Show resolved
Hide resolved
...ase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java
Outdated
Show resolved
Hide resolved
...ase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java
Outdated
Show resolved
Hide resolved
...ase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java
Outdated
Show resolved
Hide resolved
LGTM. PTAL - updated the PR. |
andirayo
approved these changes
May 20, 2020
ankitaj224
added a commit
that referenced
this pull request
May 20, 2020
* Dropping guava and appcompat dependency from FIS SDK. * Fix OverlappingFileLockException. Access the data shared by multiple threads only after acquiring cross-process and multi-thread safe locks. * Completing getId call with the disk reads on the caller thread. Also, fixing delete API to access persisted FID using cross process safe locks. * Addressing Fred's comments * Remove unused variable * Cache FID to avoid multiple disk reads. (#1571) * Cache FID to avoid multiple disk reads. * Addressing Rayo's comments. * Addressing Rayo's comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.