Skip to content

Warn when stream is closing due to error, not debug. #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

Warn when stream is closing due to error, not debug. #1561

merged 1 commit into from
May 15, 2020

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented May 14, 2020 •
edited
Loading

b/155897356

@wu-hui wu-hui requested a review from dconeybe May 14, 2020 17:34
@googlebot googlebot added the cla: yes Override cla label May 14, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (08ecaa8) Head (4a6cc2f0) Diff
    apk (aggressive) 82.5 kB 82.5 kB -3 B (-0.0%)
    apk (debug) 770 kB 770 kB -45 B (-0.0%)

  • firebase-components

    Type Base (08ecaa8) Head (4a6cc2f0) Diff
    apk (debug) 35.9 kB 35.9 kB +11 B (+0.0%)

  • firebase-database-collection

    Type Base (08ecaa8) Head (4a6cc2f0) Diff
    apk (aggressive) 314 kB 314 kB -15 B (-0.0%)
    apk (debug) 1.07 MB 1.07 MB -97 B (-0.0%)

  • firebase-firestore

    Type Base (08ecaa8) Head (4a6cc2f0) Diff
    aar 1.07 MB 1.07 MB +26 B (+0.0%)
    apk (aggressive) 443 kB 443 kB +4 B (+0.0%)
    apk (debug) 3.74 MB 3.74 MB +167 B (+0.0%)

  • protolite-well-known-types

    Type Base (08ecaa8) Head (4a6cc2f0) Diff
    apk (aggressive) 122 kB 122 kB +21 B (+0.0%)
    apk (debug) 643 kB 643 kB +2 B (+0.0%)

Test Logs

Notes

Head commit (4a6cc2f0) is created by Prow via merging commits: 08ecaa8 f5fa921.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (08ecaa8) and head commit (4a6cc2f0).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (4a6cc2f0) is created by Prow via merging commits: 08ecaa8 f5fa921.

@dconeybe dconeybe assigned wu-hui and unassigned dconeybe May 15, 2020
@wu-hui wu-hui merged commit 1a13ce2 into master May 15, 2020
@firebase firebase locked and limited conversation to collaborators Jun 15, 2020
@wu-hui wu-hui deleted the wuandy/WarnWithStreamClosing branch December 10, 2020 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu-hui @google-oss-bot @dconeybe @googlebot