Audit code to ensure printf style templates are compile time constants. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the format string is not, it could be imfluenced by error messages or user input, and could possibly include illegal format specifiers (such as %p). While not as dangerous as in C/C++, this can cause exceptions to be thrown, which is especially bad, since the reason we're printf'ing is typically because we're in the middle of error handling. As part of this, I've audited usages of: - f.f.util.Assert.hardAssert - f.f.util.Assert.fail - f.f.util.Logger.warn - f.f.util.Logger.debug - java.lang.String.format
wilhuff
approved these changes
Sep 12, 2018
| @@ -306,7 +306,7 @@ public void transactionsRequireCorrectDocumentReferences() { | |||
| try { | |||
| transaction.get(badRef); | |||
| } catch (FirebaseFirestoreException e) { | |||
| fail("transaction.get() triggered wrong exception: " + e); | |||
| fail("transaction.get() triggered wrong exception: %s", e); | |||
There was a problem hiding this comment.
Shouldn't this also be fail(e, "transaction.get ...")?
There was a problem hiding this comment.
Oops; there's two mistakes here:
Shouldn't this also be fail(e, "transaction.get ...")?
Mistake 1: yeah. Or it would be except:
2: This is actually junit's fail() method, not Assert.fail(), and thus, this line should've been unchanged. Fixed.
There was a problem hiding this comment.
I think there's a few more of these too. I'll recheck *Test.java.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the format string is not, it could be imfluenced by error messages
or user input, and could possibly include illegal format specifiers
(such as %p). While not as dangerous as in C/C++, this can cause
exceptions to be thrown, which is especially bad, since the reason we're
printf'ing is typically because we're in the middle of error handling.
As part of this, I've audited usages of: