Skip to content

Remove nested maybe #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove nested maybe #1490

wants to merge 3 commits into from

Conversation

ashwinraghav
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Apr 22, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (2f8e8ac) and head commit (704f568).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (aggressive) 85.3 kB 85.3 kB +15 B (+0.0%)
    apk (debug) 894 kB 894 kB +47 B (+0.0%)

  • firebase-common

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (aggressive) 82.5 kB 82.5 kB -1 B (-0.0%)
    apk (debug) 770 kB 770 kB -14 B (-0.0%)

  • firebase-components

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (debug) 35.9 kB 35.8 kB -30 B (-0.1%)

  • firebase-datatransport

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (aggressive) 117 kB 117 kB -17 B (-0.0%)
    apk (debug) 846 kB 846 kB -31 B (-0.0%)

  • firebase-encoders-json

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (debug) 27.4 kB 27.4 kB +2 B (+0.0%)

  • firebase-inappmessaging

    Type Base (2f8e8ac) Head (704f568) Diff
    aar 469 kB 469 kB -490 B (-0.1%)
    apk (aggressive) 854 kB 854 kB -195 B (-0.0%)
    apk (debug) 4.29 MB 4.29 MB -232 B (-0.0%)
    apk (release) 3.55 MB 3.55 MB -97 B (-0.0%)

  • protolite-well-known-types

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (aggressive) 122 kB 122 kB +3 B (+0.0%)
    apk (debug) 643 kB 643 kB +7 B (+0.0%)

  • transport-api

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (debug) 23.0 kB 23.0 kB +17 B (+0.1%)

  • transport-backend-cct

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (aggressive) 47.9 kB 47.9 kB -1 B (-0.0%)
    apk (debug) 101 kB 101 kB +4 B (+0.0%)

  • transport-runtime

    Type Base (2f8e8ac) Head (704f568) Diff
    apk (aggressive) 35.6 kB 35.6 kB -3 B (-0.0%)
    apk (debug) 80.5 kB 80.5 kB -20 B (-0.0%)

Test Logs

@yifanyang yifanyang mentioned this pull request Apr 30, 2020
Merged
@rlazo rlazo closed this Feb 20, 2024
@firebase firebase locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashwinraghav @google-oss-bot @rlazo @googlebot