Fix FIAM ANR Issue 1430 #1488
Merged
Fix FIAM ANR Issue 1430 #1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with |
Binary Size ReportAffected SDKs
Test Logs |
prakhar1989
approved these changes
Apr 21, 2020
...base-inappmessaging/src/main/java/com/google/firebase/inappmessaging/internal/ApiClient.java
Show resolved
Hide resolved
...ase-inappmessaging/src/main/java/com/google/firebase/inappmessaging/internal/GrpcClient.java
Show resolved
Hide resolved
...ing/src/main/java/com/google/firebase/inappmessaging/internal/InAppMessageStreamManager.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // blocking get occurs on the IO thread because that's what we observeOn above | ||
| return Maybe.fromCallable(getIID::blockingGet) |
There was a problem hiding this comment.
You should be able to just return getIID here, which is already a Maybe
There was a problem hiding this comment.
ah but I need to do blocking get which turns it into a not maybe, if I don't do blocking get here the waiting ends up hitting the main thread below
...ing/src/main/java/com/google/firebase/inappmessaging/internal/InAppMessageStreamManager.java
Show resolved
Hide resolved
| if (!dataCollectionHelper.isAutomaticDataCollectionEnabled()) { | ||
| Logging.logi( | ||
| "Automatic data collection is disabled, not attempting campaign fetch from service."); | ||
| return Maybe.just(cacheExpiringResponse()); |
There was a problem hiding this comment.
Thinking out loud: Can this be modelled as an empty as well, similar to IID?
There was a problem hiding this comment.
hmm maybe but I think this is pretty clear
There was a problem hiding this comment.
like it could map to empty or something like that but I think it's not worth it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.