Skip to content

Wait for DataTransport callback task at crash time #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020

Conversation

mrwillis21
Copy link
Contributor

Improves reliability of sending crash reports at crash time in the
case that the process would exit before Crashlytics has received
the asynchronous callback from DataTransport.

Improves reliability of sending crash reports at crash time in the
case that the process would exit before Crashlytics has received
the asynchronous callback from DataTransport.
@googlebot googlebot added the cla: yes Override cla label Apr 17, 2020
@mrwillis21 mrwillis21 requested a review from mrichards April 17, 2020 17:05
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (037e096) and head commit (5d32d78).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 17, 2020

Binary Size Report

Affected SDKs

  • base

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 10.7 kB 10.7 kB +1 B (+0.0%)
  • firebase-abt

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 85.6 kB 85.7 kB +7 B (+0.0%)
  • firebase-common

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 82.9 kB 82.9 kB +15 B (+0.0%)
  • firebase-components

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 10.9 kB 11.0 kB +17 B (+0.2%)
  • firebase-config

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 403 kB 403 kB +14 B (+0.0%)
  • firebase-crashlytics

    Type Base (037e096) Head (5d32d78) Diff
    aar 400 kB 401 kB +221 B (+0.1%)
    apk (aggressive) 599 kB 600 kB +741 B (+0.1%)
    apk (release) 1.37 MB 1.37 MB +181 B (+0.0%)
  • firebase-crashlytics-ndk

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 1.19 MB 1.19 MB +562 B (+0.0%)
    apk (release) 1.96 MB 1.96 MB +14 B (+0.0%)
  • firebase-database

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 326 kB 326 kB -10 B (-0.0%)
  • firebase-database-collection

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 314 kB 314 kB -11 B (-0.0%)
  • firebase-dynamic-links

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 328 kB 328 kB +4 B (+0.0%)
  • firebase-firestore

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 443 kB 443 kB -15 B (-0.0%)
  • firebase-inappmessaging

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 854 kB 854 kB -10 B (-0.0%)
  • firebase-inappmessaging-display

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 1.82 MB 1.82 MB -15 B (-0.0%)
  • firebase-installations-interop

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 61.7 kB 61.7 kB -17 B (-0.0%)
  • firebase-segmentation

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 802 kB 802 kB -1 B (-0.0%)
  • firebase-storage

    Type Base (037e096) Head (5d32d78) Diff
    apk (aggressive) 326 kB 326 kB -1 B (-0.0%)

Test Logs

@mrwillis21 mrwillis21 merged commit 56fc810 into master May 19, 2020
@mrwillis21 mrwillis21 deleted the crashlytics-wait-for-datatransport-callback branch May 19, 2020 18:19
@firebase firebase locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants