Skip to content

Upgrade robolectric and target api 29. #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2020
Merged

Upgrade robolectric and target api 29. #1469

merged 6 commits into from
Apr 15, 2020

Conversation

vkryachko
Copy link
Member

@vkryachko vkryachko commented Apr 15, 2020 •
edited
Loading

This change mostly addresses: robolectric/robolectric#5456

@googlebot googlebot added the cla: yes Override cla label Apr 15, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • base

    Type Base (8908ccf) Head (f4e1c88) Diff
    apk (aggressive) 10.7 kB 10.7 kB +7 B (+0.1%)
    apk (release) 8.75 kB 8.74 kB -15 B (-0.2%)

  • firebase-abt

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 35.4 kB 35.4 kB +2 B (+0.0%)
    apk (aggressive) 85.6 kB 85.6 kB +24 B (+0.0%)
    apk (release) 747 kB 747 kB +235 B (+0.0%)

  • firebase-common

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 34.6 kB 34.6 kB +5 B (+0.0%)
    apk (aggressive) 82.9 kB 82.9 kB -19 B (-0.0%)
    apk (release) 647 kB 647 kB +187 B (+0.0%)

  • firebase-components

    Type Base (8908ccf) Head (f4e1c88) Diff
    apk (aggressive) 11.0 kB 11.0 kB -9 B (-0.1%)
    apk (release) 25.7 kB 25.7 kB -12 B (-0.0%)

  • firebase-config

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 215 kB 215 kB +53 B (+0.0%)
    apk (aggressive) 403 kB 403 kB +469 B (+0.1%)
    apk (release) 1.16 MB 1.16 MB +738 B (+0.1%)

  • firebase-crashlytics

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 401 kB 400 kB -559 B (-0.1%)
    apk (aggressive) 598 kB 599 kB +974 B (+0.2%)
    apk (release) 1.37 MB 1.37 MB +768 B (+0.1%)

  • firebase-crashlytics-ndk

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 599 kB 599 kB +2 B (+0.0%)
    apk (aggressive) 1.19 MB 1.19 MB +1.03 kB (+0.1%)
    apk (release) 1.96 MB 1.96 MB +608 B (+0.0%)

  • firebase-database

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 482 kB 482 kB +32 B (+0.0%)
    apk (aggressive) 326 kB 326 kB +287 B (+0.1%)
    apk (release) 1.10 MB 1.10 MB +844 B (+0.1%)

  • firebase-database-collection

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 34.2 kB 34.2 kB -1 B (-0.0%)
    apk (aggressive) 314 kB 314 kB +253 B (+0.1%)
    apk (release) 913 kB 913 kB +230 B (+0.0%)

  • firebase-datatransport

    Type Base (8908ccf) Head (f4e1c88) Diff
    apk (aggressive) 117 kB 117 kB +45 B (+0.0%)
    apk (release) 713 kB 713 kB +329 B (+0.0%)

  • firebase-dynamic-links

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 51.1 kB 51.2 kB +3 B (+0.0%)
    apk (aggressive) 327 kB 328 kB +280 B (+0.1%)
    apk (release) 951 kB 952 kB +444 B (+0.0%)

  • firebase-dynamic-links:ktx

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 7.88 kB 7.88 kB -1 B (-0.0%)

  • firebase-firestore

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 1.07 MB 1.07 MB +79 B (+0.0%)
    apk (aggressive) 443 kB 443 kB +342 B (+0.1%)
    apk (release) 3.14 MB 3.14 MB +2.38 kB (+0.1%)

  • firebase-functions

    Type Base (8908ccf) Head (f4e1c88) Diff
    apk (aggressive) 393 kB 394 kB +369 B (+0.1%)
    apk (release) 1.18 MB 1.18 MB +1.10 kB (+0.1%)

  • firebase-inappmessaging

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 468 kB 467 kB -32 B (-0.0%)
    apk (aggressive) 853 kB 854 kB +969 B (+0.1%)
    apk (release) 3.55 MB 3.56 MB +2.62 kB (+0.1%)

  • firebase-inappmessaging-display

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 167 kB 168 kB +1.29 kB (+0.8%)
    apk (aggressive) 1.82 MB 1.82 MB +2.14 kB (+0.1%)
    apk (release) 4.82 MB 4.83 MB +5.85 kB (+0.1%)

  • firebase-inappmessaging-display:ktx

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 22.8 kB 22.8 kB -1 B (-0.0%)

  • firebase-installations

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 57.5 kB 57.5 kB -15 B (-0.0%)
    apk (aggressive) 84.5 kB 84.5 kB +4 B (+0.0%)
    apk (release) 666 kB 666 kB +441 B (+0.1%)

  • firebase-installations-interop

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 7.51 kB 7.51 kB +1 B (+0.0%)
    apk (aggressive) 61.7 kB 61.7 kB -4 B (-0.0%)
    apk (release) 616 kB 616 kB +210 B (+0.0%)

  • firebase-segmentation

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 34.8 kB 34.8 kB -59 B (-0.2%)
    apk (aggressive) 802 kB 802 kB +387 B (+0.0%)
    apk (release) 1.39 MB 1.39 MB +1.04 kB (+0.1%)

  • firebase-storage

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 119 kB 119 kB -1 B (-0.0%)
    apk (aggressive) 326 kB 326 kB +289 B (+0.1%)
    apk (release) 977 kB 977 kB +431 B (+0.0%)

  • protolite-well-known-types

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 1.20 MB 1.20 MB +420 B (+0.0%)
    apk (aggressive) 122 kB 122 kB -7 B (-0.0%)
    apk (release) 561 kB 561 kB +365 B (+0.1%)

  • transport:transport-api

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 6.44 kB 6.44 kB -3 B (-0.0%)

  • transport:transport-backend-cct

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 38.9 kB 38.8 kB -141 B (-0.4%)

  • transport:transport-runtime

    Type Base (8908ccf) Head (f4e1c88) Diff
    aar 126 kB 126 kB +20 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2020 •
edited
Loading

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage did not change between base commit (8908ccf) and head commit (f4e1c88). However there are changes in individual files.

    Filename Base (8908ccf) Head (f4e1c88) Diff
    BooleanNode.java 100.00% 92.31% -7.69%
    ChildChangeAccumulator.java 83.87% 96.77% +12.90%
    DoubleNode.java 88.89% 100.00% +11.11%
    TrackedQuery.java 53.85% 46.15% -7.69%
    WebsocketConnection.java 34.29% 32.00% -2.29%

  • transport-runtime

    SDK overall coverage did not change between base commit (8908ccf) and head commit (f4e1c88). However there are changes in individual files.

    Filename Base (8908ccf) Head (f4e1c88) Diff
    SQLiteEventStore.java 51.28% 51.46% +0.18%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

@VinayGuthal VinayGuthal self-requested a review April 15, 2020 20:44
ashwinraghav
ashwinraghav reviewed Apr 15, 2020
View reviewed changes
buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/ClosureUtil.java
import groovy.lang.Closure;
import java.util.function.Consumer;

public final class ClosureUtil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can You help understand what this does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to express the following in java(this api is not java-friendly):

android.testOptions.unitTests.all {
 // this is a groovy closure that is hard to implement in java, hence this util class
}

@vkryachko vkryachko merged commit 41ad413 into master Apr 15, 2020
@vkryachko vkryachko deleted the vk.jdk11_changes branch April 21, 2020 15:28
@firebase firebase locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwinraghav ashwinraghav ashwinraghav approved these changes

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vkryachko @google-oss-bot @ashwinraghav @VinayGuthal @googlebot