Forbid queries endAt an uncommitted server timestamp. #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
approved these changes
Nov 22, 2018
| collection | ||
| .orderBy("timestamp") | ||
| .endAt(docSnap) | ||
| .addSnapshotListener((snapshot2, error2) -> {})); |
There was a problem hiding this comment.
Is addSnapshotListener necessary?
There was a problem hiding this comment.
Not strictly. It is necessary to trigger the internal error that would otherwise occur though. For that reason, I'd like to keep the snapshot listener in the 'online' case just a few lines down. And if I'm keeping it there, then keeping it here for symmetry seems to make some sense. (Though I don't mind removing it either.) wdyt?
|
/retest |
rsgowman
added a commit
to firebase/firebase-js-sdk
that referenced
this pull request
Feb 11, 2019
Without this, it still fails, but: a) not until serializing the query, and b) the error is an internal error, and c) the error message is quite cryptic and has nothing to do with the problem. Port of firebase/firebase-android-sdk#138
rsgowman
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Feb 12, 2019
Without this, it still fails, but: a) not until serializing the query, and b) the error is an internal error, and c) the error message is quite cryptic and has nothing to do with the problem. Port of firebase/firebase-android-sdk#138
rsgowman
added a commit
to firebase/firebase-js-sdk
that referenced
this pull request
Feb 12, 2019
* Forbid queries endAt an uncommitted server timestamp. Without this, it still fails, but: a) not until serializing the query, and b) the error is an internal error, and c) the error message is quite cryptic and has nothing to do with the problem. Port of firebase/firebase-android-sdk#138
rsgowman
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Feb 13, 2019
Without this, it still fails, but: a) not until serializing the query, and b) the error is an internal error, and c) the error message is quite cryptic and has nothing to do with the problem. Port of firebase/firebase-android-sdk#138
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it still fails, but:
a) not until serializing the query, and
b) the error is an internal error, and
c) the error message is quite cryptic and has nothing to do with the problem.