Crashlytics ndk datatransport #1356

jakeouellette · 2020-03-17T13:04:31Z

Add datatransport connection for NDK

codecov · 2020-03-17T13:10:37Z

Codecov Report

Merging #1356 into master will decrease coverage by 50.26%.
The diff coverage is 3.06%.

Flag	Coverage Δ	Complexity Δ
#Encoders_FirebaseEncodersJson	`?`	`?`
#Encoders_FirebaseEncodersProcessor	`?`	`?`
#Encoders_FirebaseEncodersReflective	`?`	`?`
#FirebaseAbt	`?`	`?`
#FirebaseCommon	`?`	`?`
#FirebaseCommon_DataCollectionTests	`?`	`?`
#FirebaseCommon_Ktx	`?`	`?`
#FirebaseComponents	`?`	`?`
#FirebaseConfig	`?`	`?`
#FirebaseConfig_Ktx	`?`	`?`
#FirebaseCrashlytics	`2.43% <3.06%> (-0.06%)`	`22 <3> (-1)`
#FirebaseDatabase	`?`	`?`
#FirebaseDatabaseCollection	`?`	`?`
#FirebaseDatabase_Ktx	`?`	`?`
#FirebaseDatatransport	`?`	`?`
#FirebaseDynamicLinks	`?`	`?`
#FirebaseDynamicLinks_Ktx	`?`	`?`
#FirebaseFirestore	`?`	`?`
#FirebaseFirestore_Ktx	`?`	`?`
#FirebaseFunctions	`?`	`?`
#FirebaseFunctions_Ktx	`?`	`?`
#FirebaseInappmessaging	`?`	`?`
#FirebaseInappmessagingDisplay	`?`	`?`
#FirebaseInappmessagingDisplay_Ktx	`?`	`?`
#FirebaseInappmessaging_Ktx	`?`	`?`
#FirebaseInstallations	`?`	`?`
#FirebaseSegmentation	`?`	`?`
#FirebaseStorage	`?`	`?`
#FirebaseStorage_Ktx	`?`	`?`
#Tools_Errorprone	`?`	`?`
#Tools_Lint	`?`	`?`
#Transport_TransportBackendCct	`?`	`?`
#Transport_TransportRuntime	`?`	`?`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16669ad...5c3f488. Read the comment docs.

google-oss-bot · 2020-03-17T13:14:21Z

Binary Size Report

Affected SDKs

SDK	Type	Base (`1d836a1`)	Head (`5c3f488`)	Diff
firebase-inappmessaging	apk (release)	?	3256653.00	? (?)
	aar	?	467661.00	? (?)
	apk (aggressive)	?	601334.00	? (?)
firebase-common:ktx	aar	?	5965.00	? (?)
protolite-well-known-types	apk (release)	?	561089.00	? (?)
	aar	?	1203203.00	? (?)
	apk (aggressive)	?	122378.00	? (?)
firebase-inappmessaging:ktx	aar	?	5003.00	? (?)
firebase-segmentation	apk (release)	?	1667839.00	? (?)
	aar	?	35427.00	? (?)
	apk (aggressive)	?	1017144.00	? (?)
firebase-database:ktx	aar	?	6706.00	? (?)
firebase-functions:ktx	aar	?	5844.00	? (?)
firebase-storage	apk (release)	?	976604.00	? (?)
	aar	?	119257.00	? (?)
	apk (aggressive)	?	325641.00	? (?)
firebase-common	apk (release)	?	646638.00	? (?)
	aar	?	34517.00	? (?)
	apk (aggressive)	?	82939.00	? (?)
encoders:firebase-encoders-json	aar	?	15334.00	? (?)
firebase-firestore:ktx	aar	?	7093.00	? (?)
firebase-crashlytics-ndk	apk (release)	?	1935918.00	? (?)
	aar	?	598746.00	? (?)
	apk (aggressive)	?	1170090.00	? (?)
transport:transport-api	aar	?	6439.00	? (?)
transport:transport-backend-cct	aar	?	38343.00	? (?)
firebase-inappmessaging-display:ktx	aar	?	22190.00	? (?)
firebase-database	apk (release)	?	1101570.00	? (?)
	aar	?	480458.00	? (?)
	apk (aggressive)	?	325592.00	? (?)
encoders:firebase-encoders-reflective	aar	?	7650.00	? (?)
firebase-crashlytics	apk (release)	?	1352970.00	? (?)
	aar	?	397599.00	? (?)
	apk (aggressive)	?	583388.00	? (?)
transport:transport-runtime	aar	?	122725.00	? (?)
firebase-installations	apk (release)	?	665523.00	? (?)
	aar	?	55059.00	? (?)
	apk (aggressive)	?	84602.00	? (?)
firebase-config:ktx	aar	?	6162.00	? (?)
firebase-dynamic-links	apk (release)	?	951227.00	? (?)
	aar	?	51149.00	? (?)
	apk (aggressive)	?	327448.00	? (?)
firebase-storage:ktx	aar	?	6143.00	? (?)
firebase-installations-interop	apk (release)	?	616109.00	? (?)
	aar	?	7509.00	? (?)
	apk (aggressive)	?	61713.00	? (?)
firebase-components	apk (release)	?	25749.00	? (?)
	aar	?	34495.00	? (?)
	apk (aggressive)	?	10966.00	? (?)
firebase-abt	apk (release)	?	746406.00	? (?)
	aar	?	35383.00	? (?)
	apk (aggressive)	?	85702.00	? (?)
firebase-config	apk (release)	?	1143995.00	? (?)
	aar	?	214548.00	? (?)
	apk (aggressive)	?	395831.00	? (?)
firebase-datatransport	apk (release)	?	711399.00	? (?)
	aar	?	5041.00	? (?)
	apk (aggressive)	?	116364.00	? (?)
firebase-dynamic-links:ktx	aar	?	7877.00	? (?)
firebase-inappmessaging-display	apk (release)	?	4520174.00	? (?)
	aar	?	165930.00	? (?)
	apk (aggressive)	?	1603057.00	? (?)
firebase-functions	apk (release)	?	1178560.00	? (?)
	aar	?	25859.00	? (?)
	apk (aggressive)	?	393455.00	? (?)
firebase-database-collection	apk (release)	?	912665.00	? (?)
	aar	?	34214.00	? (?)
	apk (aggressive)	?	313622.00	? (?)
firebase-firestore	apk (release)	?	3139763.00	? (?)
	aar	?	1067674.00	? (?)
	apk (aggressive)	?	443174.00	? (?)
base	apk (release)	?	8754.00	? (?)
base	apk (aggressive)	?	10676.00	? (?)

Metric Unit: byte

Test Logs

https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/1356/binary-size/1240741492574654470

mrwillis21

In addition to the inline comments, you'll probably need to add the NDK payload to the JSON transformer. I can help with that if you need.

...c/main/java/com/google/firebase/crashlytics/internal/common/FileBackedNativeSessionFile.java

...hlytics/src/main/java/com/google/firebase/crashlytics/internal/common/NativeSessionFile.java

.../src/main/java/com/google/firebase/crashlytics/internal/common/NativeSessionFileGzipper.java

...c/main/java/com/google/firebase/crashlytics/internal/common/SessionReportingCoordinator.java

...shlytics/src/main/java/com/google/firebase/crashlytics/internal/model/CrashlyticsReport.java

…f session parts

… values

mrwillis21 · 2020-03-18T19:37:19Z

...lytics/src/main/java/com/google/firebase/crashlytics/internal/common/DataTransportState.java

+    return ALL;
+  }
+
+  static DataTransportState getState(AppSettingsData appSettingsData) {


Add a test here?

- Update logs to prevent confusion around whether logs were sent

jakeouellette · 2020-03-19T20:52:10Z

last 2 commits LGTM

googlebot added the cla: yes Override cla label Mar 17, 2020

google-oss-bot added the size/XL label Mar 17, 2020

jakeouellette force-pushed the crashlytics-ndk-datatransport branch 2 times, most recently from fed4082 to 15f091c Compare March 17, 2020 13:07

mrwillis21 reviewed Mar 17, 2020

View reviewed changes

jakeouellette force-pushed the crashlytics-ndk-datatransport branch 2 times, most recently from 13a9d6f to 8139b0a Compare March 17, 2020 20:57

google-oss-bot added size/XXL and removed size/XL labels Mar 17, 2020

mrwillis21 and others added 15 commits March 18, 2020 11:11

Add FilesPayload for NDK reports

54ab654

WIP

3a1d179

Implement strategy pattern for native sessions

9d5bc02

Prep for next iteration

aae1642

Refactor datatransport abstractions to support polymorphic handling o…

84c793c

…f session parts

Address feedback

70be19a

style

867e464

remove UTF-8

89e196e

Add test classes

8371820

Add tests

7a76a10

Add tests and serialization of ndkpayload

745cd56

Add settings field for NDK sessions through DataTransport

1d16106

Wire up settings to send procedure

d533e8b

Interleave native and non-native high priority sessions

a924bb2

Add session ID abstraction to facilitate deleting NDK reports

fcc5426

mrwillis21 force-pushed the crashlytics-ndk-datatransport branch from 9af8374 to fcc5426 Compare March 18, 2020 15:11

jakeouellette and others added 3 commits March 18, 2020 13:27

Add tests for session coordinator and report persistence

1796c16

Make Firebase session ID for native sessions

bcacb59

Add support for sending/deleting native crashes based on the settings…

56a4eeb

… values

mrwillis21 reviewed Mar 18, 2020

View reviewed changes

mrwillis21 and others added 9 commits March 18, 2020 15:56

Cleanup

75257bf

Remove undone testS

21313d7

Cleanup

9173669

Base ndk sessions on non-ndk sessions

3d231e2

Update paths to allow firelog to go to a different filename.

365d773

- Update logs to prevent confusion around whether logs were sent

Make try { } catches less wide

cba4bff

Remove old withUserId method

8d54a9c

Add null check for withSessionEndFields

f2f3db3

Replace builder with simpler create method

5c3f488

mrwillis21 approved these changes Mar 19, 2020

View reviewed changes

mrwillis21 merged commit 3f5146f into master Mar 19, 2020

mrwillis21 deleted the crashlytics-ndk-datatransport branch March 19, 2020 21:03

firebase locked and limited conversation to collaborators Apr 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Crashlytics ndk datatransport #1356

Crashlytics ndk datatransport #1356

Uh oh!

jakeouellette commented Mar 17, 2020

Uh oh!

codecov bot commented Mar 17, 2020 •

edited

Loading

Uh oh!

google-oss-bot commented Mar 17, 2020 •

edited

Loading

Uh oh!

mrwillis21 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrwillis21 Mar 18, 2020

Uh oh!

jakeouellette commented Mar 19, 2020

Uh oh!

Uh oh!

Crashlytics ndk datatransport #1356

Crashlytics ndk datatransport #1356

Uh oh!

Conversation

jakeouellette commented Mar 17, 2020

Uh oh!

codecov bot commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

google-oss-bot commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

Test Logs

Uh oh!

mrwillis21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrwillis21 Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

jakeouellette commented Mar 19, 2020

Uh oh!

Uh oh!

codecov bot commented Mar 17, 2020 •

edited

Loading

google-oss-bot commented Mar 17, 2020 •

edited

Loading