Skip to content

Add unionWith to SortedSet. #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2020
Merged

Add unionWith to SortedSet. #1241

merged 3 commits into from
Feb 13, 2020

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Feb 13, 2020

This is a port of firebase/firebase-js-sdk#2624, to fix a performance regression.

@googlebot googlebot added the cla: yes Override cla label Feb 13, 2020
@wu-hui wu-hui requested a review from wilhuff February 13, 2020 17:56
wilhuff
wilhuff approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned wu-hui and unassigned wilhuff Feb 13, 2020
@wu-hui
Copy link
Contributor Author

wu-hui commented Feb 13, 2020

/retest

@wu-hui wu-hui merged commit 939be87 into master Feb 13, 2020
@firebase firebase locked and limited conversation to collaborators Mar 15, 2020
@kaibolay kaibolay deleted the wuandy/AddUnionWithToSortedSet branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@wu-hui wu-hui

Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu-hui @wilhuff @googlebot @google-oss-bot