Skip to content

Add support for ignoring nulls in JsonDataEncoder #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2020

Conversation

mrwillis21
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jan 29, 2020
@mrwillis21 mrwillis21 requested a review from rlazo January 29, 2020 20:37
Copy link
Collaborator

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeeeeet

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject encoders_firebase-encoders-json:
error: Added method com.google.firebase.encoders.json.JsonDataEncoderBuilder.ignoreNulls(boolean) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1175 into master will increase coverage by 20.87%.
The diff coverage is 100%.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson 95.93% <100%> (-4.07%) 68 <8> (+68)
#Encoders_FirebaseEncodersProcessor ? ?
#Encoders_FirebaseEncodersReflective 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseAbt ? ?
#FirebaseCommon ? ?
#FirebaseCommon_DataCollectionTests ? ?
#FirebaseCommon_Ktx ? ?
#FirebaseComponents ? ?
#FirebaseConfig ? ?
#FirebaseConfig_Ktx ? ?
#FirebaseCrashlytics ? ?
#FirebaseDatabase ? ?
#FirebaseDatabaseCollection ? ?
#FirebaseDatabase_Ktx ? ?
#FirebaseDatatransport 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseDynamicLinks ? ?
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore ? ?
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions ? ?
#FirebaseFunctions_Ktx ? ?
#FirebaseInappmessaging 68% <ø> (-32%) 391 <ø> (+391)
#FirebaseInappmessagingDisplay ? ?
#FirebaseInappmessagingDisplay_Ktx ? ?
#FirebaseInappmessaging_Ktx ? ?
#FirebaseInstallations ? ?
#FirebaseSegmentation ? ?
#FirebaseStorage ? ?
#FirebaseStorage_Ktx ? ?
#Tools_Errorprone ? ?
#Tools_Lint ? ?
#Transport_TransportBackendCct 91.02% <ø> (-8.98%) 142 <ø> (+142)
#Transport_TransportRuntime ? ?
Impacted Files Coverage Δ Complexity Δ
...e/encoders/json/JsonValueObjectEncoderContext.java 96.66% <100%> (+0.23%) 56 <6> (+4) ⬆️
...firebase/encoders/json/JsonDataEncoderBuilder.java 93.02% <100%> (+0.52%) 10 <2> (+2) ⬆️
...android/datatransport/cct/internal/LogRequest.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...e/android/datatransport/cct/CctBackendFactory.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...ndroid/datatransport/cct/internal/LogResponse.java 100% <0%> (ø) 6% <0%> (ø) ⬇️
...ort/cct/internal/JsonBatchedLogRequestEncoder.java 88.88% <0%> (ø) 1% <0%> (ø) ⬇️
.../datatransport/cct/internal/ClientInfoEncoder.java 66.66% <0%> (ø) 2% <0%> (ø) ⬇️
...e/android/datatransport/cct/internal/LogEvent.java 100% <0%> (ø) 4% <0%> (ø) ⬇️
...ansport/cct/internal/BatchedLogRequestEncoder.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
.../datatransport/cct/internal/LogRequestEncoder.java 81.25% <0%> (ø) 5% <0%> (ø) ⬇️
... and 689 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f71bb...202f3f9. Read the comment docs.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject encoders_firebase-encoders-json:
error: Added method com.google.firebase.encoders.json.JsonDataEncoderBuilder.ignoreNullValues(boolean) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@mrwillis21 mrwillis21 force-pushed the add-encoder-ignore-nulls branch from ae2ca18 to 202f3f9 Compare January 30, 2020 16:31
@mrwillis21 mrwillis21 merged commit 58ce4c0 into master Jan 30, 2020
@mrwillis21 mrwillis21 deleted the add-encoder-ignore-nulls branch January 30, 2020 18:06
@firebase firebase locked and limited conversation to collaborators Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants