Skip to content

Add verify support #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Add verify support #1107

merged 3 commits into from
Jan 9, 2020

Conversation

thebrianchen
Copy link

Port from JS.

@googlebot googlebot added the cla: yes Override cla label Jan 9, 2020
@thebrianchen thebrianchen added api: firestore and removed cla: yes Override cla labels Jan 9, 2020
@thebrianchen thebrianchen self-assigned this Jan 9, 2020
@googlebot googlebot added the cla: yes Override cla label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #1107 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1107      +/-   ##
============================================
+ Coverage     53.37%   53.38%   +0.01%     
- Complexity     6400     6410      +10     
============================================
  Files           719      720       +1     
  Lines         34853    34870      +17     
  Branches       4624     4626       +2     
============================================
+ Hits          18603    18616      +13     
- Misses        14769    14774       +5     
+ Partials       1481     1480       -1
Impacted Files Coverage Δ Complexity Δ
...om/google/firebase/firestore/core/Transaction.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ebase/firestore/model/mutation/VerifyMutation.java 30.76% <30.76%> (ø) 2 <2> (?)
...le/firebase/firestore/remote/RemoteSerializer.java 79.31% <66.66%> (+0.69%) 147 <0> (+4) ⬆️
...google/firebase/database/snapshot/BooleanNode.java 84.61% <0%> (-7.7%) 12% <0%> (-1%)
...a/com/google/firebase/database/core/WriteTree.java 76.24% <0%> (-1.11%) 53% <0%> (-1%)
...va/com/google/firebase/database/core/SyncTree.java 62.25% <0%> (+0.25%) 40% <0%> (ø) ⬇️
...n/java/com/google/firebase/storage/UploadTask.java 72.52% <0%> (+1.09%) 47% <0%> (+1%) ⬆️
...irebase/firestore/model/mutation/Precondition.java 57.14% <0%> (+5.71%) 19% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227121f...afa229d. Read the comment docs.

@thebrianchen thebrianchen requested a review from wilhuff January 9, 2020 21:31
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Jan 9, 2020
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Jan 9, 2020
@thebrianchen thebrianchen merged commit ef38ef7 into master Jan 9, 2020
@thebrianchen thebrianchen deleted the bc/verify branch January 9, 2020 23:03
@firebase firebase locked and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants