Skip to content

Configure kotlindoc generation per SDK. #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Conversation

vkryachko
Copy link
Member

This makes it easier to generate docs for a subset of SDKs, additionally
it produces a set of separate _toc.yaml files as opposed to a global one.

This makes it easier to generate docs for a subset of SDKs, additionally
it produces a set of separate _toc.yaml files as opposed to a global one.
@vkryachko vkryachko requested a review from rlazo January 9, 2020 19:20
@googlebot googlebot added the cla: yes Override cla label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #1106 into master will decrease coverage by 4.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1106      +/-   ##
============================================
- Coverage     57.56%   53.42%   -4.14%     
- Complexity     6238     6408     +170     
============================================
  Files           639      719      +80     
  Lines         31367    34853    +3486     
  Branches       4323     4624     +301     
============================================
+ Hits          18055    18620     +565     
- Misses        11870    14758    +2888     
- Partials       1442     1475      +33
Impacted Files Coverage Δ Complexity Δ
...le/firebase/firestore/util/ExponentialBackoff.java 28.26% <0%> (-0.32%) 3% <0%> (ø)
...va/com/google/firebase/database/core/SyncTree.java 62% <0%> (-0.25%) 40% <0%> (ø)
...le/firebase/firestore/remote/GrpcCallProvider.java 45.45% <0%> (-0.16%) 8% <0%> (+4%)
...ions/remote/FirebaseInstallationServiceClient.java 6.66% <0%> (-0.1%) 3% <0%> (ø)
...tics/internal/stacktrace/TrimmedThrowableData.java 0% <0%> (ø) 0% <0%> (?)
...ase/crashlytics/internal/report/ReportManager.java 0% <0%> (ø) 0% <0%> (?)
...e/crashlytics/internal/ndk/ProcMapEntryParser.java 0% <0%> (ø) 0% <0%> (?)
...rashlytics/internal/ndk/BinaryImagesConverter.java 0% <0%> (ø) 0% <0%> (?)
...ytics/internal/settings/model/AppSettingsData.java 0% <0%> (ø) 0% <0%> (?)
...oogle/firebase/crashlytics/core/MetaDataStore.java 0% <0%> (ø) 0% <0%> (?)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f629ebe...de09357. Read the comment docs.

@rlazo
Copy link
Collaborator

rlazo commented Jan 9, 2020

/retest

@rlazo
Copy link
Collaborator

rlazo commented Jan 9, 2020

/test copyright-check

@vkryachko vkryachko merged commit 29f561d into master Jan 9, 2020
@firebase firebase locked and limited conversation to collaborators Feb 9, 2020
@vkryachko vkryachko deleted the vk.per_sdk_kotlindoc branch March 20, 2020 23:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants