Change the default FTL bucket to "fireescape-ftl-test-results". #1079
Conversation
FTL tests started from local will upload artifacts/logs to the new bucket. This avoids clutter in the bucket "android-ci".
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
============================================
+ Coverage 57.59% 57.61% +0.02%
- Complexity 6245 6247 +2
============================================
Files 639 639
Lines 31366 31367 +1
Branches 4323 4323
============================================
+ Hits 18064 18073 +9
+ Misses 11863 11856 -7
+ Partials 1439 1438 -1
Continue to review full report at Codecov.
|
| @@ -68,7 +67,10 @@ class FirebaseTestServer extends TestServer { | |||
| Optional<String> resultsBucket = Optional.ofNullable(System.getenv('FTL_RESULTS_BUCKET')).map(Environment.&expand) | |||
| Optional<String> resultsDir = Optional.ofNullable(System.getenv('FTL_RESULTS_DIR')).map(Environment.&expand) | |||
|
|
|||
| List<String> args = ['--results-bucket', resultsBucket.orElse(DEFAULT_BUCKET_NAME)] | |||
There was a problem hiding this comment.
Discussed offline. Changing to uploading to FTL public bucket if the environment variable for bucket is not supplied.
| List<String> args = [] | ||
| if (resultsBucket.isPresent()) { | ||
| args += ['--results-bucket', resultsBucket.get()] | ||
| } | ||
| if (resultsDir.isPresent()) { | ||
| args += ['--results-dir', Paths.get(resultsDir.get(), "${project.path}_${random.nextLong()}")] |
There was a problem hiding this comment.
nextLong can give negative numbers. I don't know if you think that is a problem.
There was a problem hiding this comment.
It has not been a problem so far, but I would not be opposed to Math.abs() on it, but totally optional.
|
@yifanyang: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
FTL tests started from local will upload artifacts/logs to the new
bucket. This avoids clutter in the bucket "android-ci".