Skip to content

Make createCombinedReport to depend only on checkCoverage tasks. #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

yifanyang
Copy link
Contributor

No description provided.

@yifanyang yifanyang requested a review from rlazo December 9, 2019 21:38
@googlebot googlebot added the cla: yes Override cla label Dec 9, 2019
@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information ec077b4 link /test api-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@93e59eb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1047   +/-   ##
=========================================
  Coverage          ?   58.35%           
  Complexity        ?     6194           
=========================================
  Files             ?      621           
  Lines             ?    30725           
  Branches          ?     4246           
=========================================
  Hits              ?    17931           
  Misses            ?    11364           
  Partials          ?     1430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e59eb...ec077b4. Read the comment docs.

@yifanyang yifanyang merged commit 7a61f82 into master Dec 9, 2019
@yifanyang yifanyang deleted the yifany/fix branch December 9, 2019 21:58
@firebase firebase locked and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants