-
Notifications
You must be signed in to change notification settings - Fork 616
Fixes for multi-process access #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
069756e
Switch from using SharedPreferences to a flat file
fredquintana f3abf1e
Fixes for multi-process access
fredquintana ac12e70
Merge branch 'fis_sdk' of https://github.com/firebase/firebase-androi…
fredquintana 804fafe
revert the name of the FID prefs write call
fredquintana f03ebc9
fix formatting issues
fredquintana 1769b09
Fix the cross process locking
fredquintana 27ecdcc
some small changes from the review
fredquintana a9b109a
fix the java format and update the api file
fredquintana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
...se-installations/src/androidTest/java/com/google/firebase/installations/FakeCalendar.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.firebase.installations; | ||
|
|
||
| import java.util.Calendar; | ||
|
|
||
| public class FakeCalendar extends Calendar { | ||
| private long timeInMillis; | ||
|
|
||
| public FakeCalendar() { | ||
| timeInMillis = 5000000; | ||
| } | ||
|
|
||
| public long getTimeInMillis() { | ||
| return timeInMillis; | ||
| } | ||
|
|
||
| public void setTimeInMillis(long timeInMillis) { | ||
| this.timeInMillis = timeInMillis; | ||
| } | ||
|
|
||
| public void advanceTimeBySeconds(long deltaSeconds) { | ||
| timeInMillis += (deltaSeconds * 1000L); | ||
| } | ||
|
|
||
| @Override | ||
| protected void computeTime() {} | ||
|
|
||
| @Override | ||
| protected void computeFields() {} | ||
|
|
||
| @Override | ||
| public void add(int i, int i1) {} | ||
|
|
||
| @Override | ||
| public void roll(int i, boolean b) {} | ||
|
|
||
| @Override | ||
| public int getMinimum(int i) { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public int getMaximum(int i) { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public int getGreatestMinimum(int i) { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public int getLeastMaximum(int i) { | ||
| return 0; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epochInMillis?
Maybe consider passing the fake current time in via the constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the start time as a constructor param.
I think "timeInMillis" is more accurate, or timeSinceEpochInMillis.