Skip to content

Fix api files. #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Fix api files. #1041

merged 2 commits into from
Dec 9, 2019

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Dec 5, 2019

Fix outdated api.txt files.

@googlebot googlebot added the cla: yes Override cla label Dec 5, 2019
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 5, 2019

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information a8be8d6 link /test api-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator Author

rlazo commented Dec 6, 2019

/test device-check-changed

@rlazo rlazo merged commit 93e59eb into master Dec 9, 2019
@rlazo rlazo deleted the rl.fixapi branch December 9, 2019 16:49
@inlined
Copy link
Member

inlined commented Dec 9, 2019

It looks like this has broken :firebase-common:ktx:apiInformation. I can't get a clean build anymore on my PR nor on master. Mind if we roll back?

@rlazo
Copy link
Collaborator Author

rlazo commented Dec 10, 2019

Actually, this PR partially fixes the issue. We believe the issue with apiInfo was actually caused by #1033 and we're actively investigating on it. Feel free to ignore failures in the test.

@firebase firebase locked and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants