Skip to content

Allow RTDB to auto-generate typings, separate internal vs external APIs #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Aug 12, 2020
Merged

Allow RTDB to auto-generate typings, separate internal vs external APIs #963

Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
10fe794
Add progress
MathBunny Jul 21, 2020
d8c4011
Add auto-generated typings for RTDB
MathBunny Jul 22, 2020
88772e3
Add back database.d.ts
MathBunny Jul 22, 2020
98ea057
Remove src/test.ts
MathBunny Jul 22, 2020
aacb3be
Add missing newline in database.d.ts
MathBunny Jul 22, 2020
ed922c0
Add progress
MathBunny Jul 22, 2020
c92e670
Add more integration tests
MathBunny Jul 22, 2020
05f5f6b
Small modifications
MathBunny Jul 22, 2020
eb8e85c
Add gulp-filter to dependencies
MathBunny Jul 22, 2020
f143097
Add gulp-filter to dependencies
MathBunny Jul 22, 2020
d78f3e5
Address broken unit tests
MathBunny Jul 23, 2020
bc939c1
Rename gulpfile task name for autogenerated typings
MathBunny Jul 23, 2020
339268f
Minor fixes
MathBunny Jul 23, 2020
d7cd563
Add extra level of nesting in the namespace export
MathBunny Jul 23, 2020
4908ee4
Add separate import for types
MathBunny Jul 23, 2020
4671dbc
Make ServerValue also use RTDB
MathBunny Jul 23, 2020
7e35aac
Address some of the comments
MathBunny Jul 23, 2020
adf7126
Undo changes to remove FirebaseApp split
MathBunny Jul 24, 2020
52c6268
Fix broken tests
MathBunny Jul 24, 2020
fe96c44
Make database have an optional app parameter
MathBunny Jul 24, 2020
41d3c46
Add working hacky fix
MathBunny Jul 24, 2020
70f687a
Set the return type to be Database
MathBunny Jul 24, 2020
9fce5a6
Add comment relating to the issue flagged for JS SDK
MathBunny Jul 24, 2020
c1a9fce
Address review comments
MathBunny Jul 24, 2020
2345654
Remove redundent import
MathBunny Jul 24, 2020
391ee40
Add environment variable based override for builds
MathBunny Jul 24, 2020
8c7301e
Do not caps lock auto
MathBunny Jul 24, 2020
9a98462
Use lowercase auto
MathBunny Jul 27, 2020
7abc876
Address gulpfile comments
MathBunny Jul 27, 2020
09434f2
Use database-types instead of database
MathBunny Jul 28, 2020
9f20af2
Fix unit test failures
MathBunny Jul 28, 2020
401fb04
Fix unit test failures
MathBunny Jul 28, 2020
b060e6e
Remove ThenableReference and EventType
MathBunny Jul 28, 2020
89b8fc8
Fix unit test failures
MathBunny Jul 28, 2020
f756136
Add attempt
MathBunny Jul 30, 2020
62515c5
Address feedback from offline conversation
MathBunny Jul 30, 2020
91beb05
Update unit test as well
MathBunny Jul 30, 2020
2ac3801
Resolve merge conflicts, update database/database-types
MathBunny Aug 7, 2020
eaf7d22
Add progress
MathBunny Aug 7, 2020
c30a909
Fix broken dependencies
MathBunny Aug 10, 2020
5ea35ba
Bump auth-types
MathBunny Aug 10, 2020
b0f2574
Merge branch 'master' of https://github.com/firebase/firebase-admin-n…
MathBunny Aug 11, 2020
07a8f9f
Remove second module augmentation
MathBunny Aug 11, 2020
d791c21
fix: Remove database from typing excludes in gulpfile
MathBunny Aug 11, 2020
03b0c46
Merge branch 'master' of https://github.com/firebase/firebase-admin-n…
MathBunny Aug 11, 2020
a18067d
fix: Address feedback
MathBunny Aug 12, 2020
a60ce75
Resolve merge conflicts
MathBunny Aug 12, 2020
200408b
fix: Do not alias Database to FirebaseDatabase
MathBunny Aug 12, 2020
8a20214
fix: Do not duplicate imports
MathBunny Aug 12, 2020
dce5640
fix: Add back getDatabase() call
MathBunny Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ var paths = {

curatedTypings: [
'src/*.d.ts',
'!src/database.d.ts',
'!src/instance-id.d.ts',
'!src/security-rules.d.ts',
'!src/project-management.d.ts',
Expand All @@ -68,7 +69,6 @@ const TEMPORARY_TYPING_EXCLUDES = [
'!lib/firebase-app.d.ts',
'!lib/firebase-service.d.ts',
'!lib/auth/*.d.ts',
'!lib/database/*.d.ts',
'!lib/firestore/*.d.ts',
'!lib/machine-learning/*.d.ts',
'!lib/storage/*.d.ts',
Expand Down
142 changes: 99 additions & 43 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,11 @@
],
"types": "./lib/index.d.ts",
"dependencies": {
"@firebase/database": "^0.6.0",
"@firebase/auth-interop-types": "^0.1.5",
"@firebase/database": "^0.6.10",
"@firebase/database-types": "^0.5.2",
"@types/node": "^10.10.0",
"dicer": "^0.3.0",
"gulp-filter": "^6.0.0",
"jsonwebtoken": "^8.5.1",
"node-forge": "^0.9.1"
},
Expand All @@ -66,9 +67,9 @@
"@google-cloud/storage": "^5.0.0"
},
"devDependencies": {
"@firebase/app": "^0.6.1",
"@firebase/auth": "^0.13.3",
"@firebase/auth-types": "^0.9.3",
"@firebase/app": "^0.6.9",
"@firebase/auth": "^0.14.9",
"@firebase/auth-types": "^0.10.1",
"@types/bcrypt": "^2.0.0",
"@types/chai": "^4.0.0",
"@types/chai-as-promised": "^7.1.0",
Expand All @@ -93,6 +94,7 @@
"eslint": "^6.8.0",
"firebase-token-generator": "^2.0.0",
"gulp": "^4.0.2",
"gulp-filter": "^6.0.0",
"gulp-header": "^1.8.8",
"gulp-replace": "^0.5.4",
"gulp-typescript": "^5.0.1",
Expand Down
Loading