feat(fcm): Support apns.live_activity_token field in FCM ApnsConfig
#2891
Conversation
| @@ -1725,6 +1725,21 @@ describe('Messaging', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| const invalidApnsLiveActivityTokens: any[] = [null, NaN, 0, 1, true, false] | |||
There was a problem hiding this comment.
perhaps we should add a test for valid payload?
There was a problem hiding this comment.
Sure thing. I added the tests with valid payloads for the live activity start | update | end events
src/messaging/messaging-api.ts
Outdated
| /** | ||
| * APN `live_activity_push_to_start_token` or `live_activity_push_token` to start or update live activities. | ||
| */ | ||
| live_activity_token?: string; |
There was a problem hiding this comment.
Exported names should be in lowerCamelCase formatting. Could you change this to liveActivityToken instead?
There was a problem hiding this comment.
Makes sense, thanks for your review!
I am not quite sure where to map the property liveActivityToken to live_activity_token as required for the HTTP API? https://firebase.google.com/docs/cloud-messaging/ios/live-activity
There was a problem hiding this comment.
also: Should the additional fields like dismissal-date content-state or attributes-type also get included and mapped? Those could also be [customData: string]: any typed
There was a problem hiding this comment.
Hi @janodetzel, The mapping should be done inside validateApnsConfig() in messaging-internal.ts. You can use validateAndroidConfig() for reference:
firebase-admin-node/src/messaging/messaging-internal.ts
Lines 415 to 420 in 6b5079e
As for additional fields, like you said the customData field should be sufficient to over any needed payload fields, so lets leave those out for now.
There was a problem hiding this comment.
Hey @jonathanedey. Amazing, thank you for this info! I implemented the property mapping and adjusted the tests.
* feat(fcm): Support `live_activity_token` field on `ApnsConfig` * added validation * update documentation
janodetzel
force-pushed
the
master
branch
2 times, most recently
from
756c68d to
1d032bd
Compare
jonathanedey
assigned chong-shao, OrlandriaH-G and jonathanedey and unassigned lahirumaramba
live_activity_tokenfield onApnsConfigFixes #2875