Skip to content

Mark sendAll and sendMulticast variants as deprecated #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Mark sendAll and sendMulticast variants as deprecated #836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8d3de0
Mark `sendAll` and `sendMulticast` variants as deprecated
vpavic Jun 23, 2023
60503c8
Merge branch 'master' into fcm-deprecations
lahirumaramba Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/com/google/firebase/messaging/FirebaseMessaging.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ public ApiFuture<BatchResponse> sendEachForMulticastAsync(
* value.
* @deprecated Use {@link #sendEach(List)} instead.
*/
@Deprecated
public BatchResponse sendAll(
@NonNull List<Message> messages) throws FirebaseMessagingException {
return sendAll(messages, false);
Expand Down Expand Up @@ -371,6 +372,7 @@ public BatchResponse sendAll(
* value.
* @deprecated Use {@link #sendEach(List, boolean)} instead.
*/
@Deprecated
public BatchResponse sendAll(
@NonNull List<Message> messages, boolean dryRun) throws FirebaseMessagingException {
return sendAllOp(messages, dryRun).call();
Expand All @@ -384,6 +386,7 @@ public BatchResponse sendAll(
* the messages have been sent.
* @deprecated Use {@link #sendEachAsync(List)} instead.
*/
@Deprecated
public ApiFuture<BatchResponse> sendAllAsync(@NonNull List<Message> messages) {
return sendAllAsync(messages, false);
}
Expand All @@ -397,6 +400,7 @@ public ApiFuture<BatchResponse> sendAllAsync(@NonNull List<Message> messages) {
* the messages have been sent, or when the emulation has finished.
* @deprecated Use {@link #sendEachAsync(List, boolean)} instead.
*/
@Deprecated
public ApiFuture<BatchResponse> sendAllAsync(
@NonNull List<Message> messages, boolean dryRun) {
return sendAllOp(messages, dryRun).callAsync(app);
Expand All @@ -418,6 +422,7 @@ public ApiFuture<BatchResponse> sendAllAsync(
* return value.
* @deprecated Use {@link #sendEachForMulticast(MulticastMessage)} instead.
*/
@Deprecated
public BatchResponse sendMulticast(
@NonNull MulticastMessage message) throws FirebaseMessagingException {
return sendMulticast(message, false);
Expand Down Expand Up @@ -445,6 +450,7 @@ public BatchResponse sendMulticast(
* return value.
* @deprecated Use {@link #sendEachForMulticast(MulticastMessage, boolean)} instead.
*/
@Deprecated
public BatchResponse sendMulticast(
@NonNull MulticastMessage message, boolean dryRun) throws FirebaseMessagingException {
checkNotNull(message, "multicast message must not be null");
Expand All @@ -460,6 +466,7 @@ public BatchResponse sendMulticast(
* the messages have been sent.
* @deprecated Use {@link #sendEachForMulticastAsync(MulticastMessage)} instead.
*/
@Deprecated
public ApiFuture<BatchResponse> sendMulticastAsync(@NonNull MulticastMessage message) {
return sendMulticastAsync(message, false);
}
Expand All @@ -474,6 +481,7 @@ public ApiFuture<BatchResponse> sendMulticastAsync(@NonNull MulticastMessage mes
* the messages have been sent.
* @deprecated Use {@link #sendEachForMulticastAsync(MulticastMessage, boolean)} instead.
*/
@Deprecated
public ApiFuture<BatchResponse> sendMulticastAsync(
@NonNull MulticastMessage message, boolean dryRun) {
checkNotNull(message, "multicast message must not be null");
Expand Down