Skip to content

feat(firestore): Add support for multiple named databases in Firestore #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023
Merged

feat(firestore): Add support for multiple named databases in Firestore #814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/google/firebase/cloud/FirestoreClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public static Firestore getFirestore(FirebaseApp app) {
* instance.
*/
@NonNull
static Firestore getFirestore(FirebaseApp app, String database) {
public static Firestore getFirestore(FirebaseApp app, String database) {
return getInstance(app, database).firestore;
}

Expand All @@ -108,7 +108,7 @@ static Firestore getFirestore(FirebaseApp app, String database) {
* instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks, were these public docs were reviewed by a tech writer before merging the changes?
@tom-andersen @wu-hui

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We involved @markarndt in multidb texts last year. The changes were repetitive across SDKs, so he didn't review all of them.

Is the process now to have tech writers mark PRs directly with approval?

*/
@NonNull
static Firestore getFirestore(String database) {
public static Firestore getFirestore(String database) {
return getFirestore(FirebaseApp.getInstance(), database);
}

Expand Down